refactor: Move solo quest state from party to client#890
Open
pacampbell wants to merge 1 commit into
Open
Conversation
Due to party invite oddities, we need to relocate the solo quest state so when players join EXM and Party Finder parties, the solo quest state will be available during the area transitions.
RyanYappert
reviewed
Jun 12, 2025
RyanYappert
left a comment
RyanYappert
left a comment
Collaborator
There was a problem hiding this comment.
I think this is mostly fine in concept because once you've loaded into the game, you can't change characters without relogging and becoming a new client?
| if (quest != null && quest.IsPersonal) | ||
| { | ||
| join.QuestState.AddNewQuest(questProgress.QuestScheduleId, questProgress.Step); | ||
| client.QuestState.AddNewQuest(questProgress.QuestScheduleId, questProgress.Step); |
Collaborator
There was a problem hiding this comment.
Is this where we want to keep this? Shouldn't this move to somewhere on login, rather than party joining, if it persists across party membership? This feels like it'll run multiple times per session whenever they join a new party, and AddNewQuest may complain if the quest is already present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to party invite oddities, we need to relocate the solo quest state so when players join EXM and Party Finder parties, the solo quest state will be available during the area transitions.
Checklist:
developbranch