Feat: Quest Schedule ID Rework + Board Quest Rotation by RyanYappert · Pull Request #822 · sebastian-heinz/Arrowgene.DragonsDogmaOnline

RyanYappert · 2025-05-14T07:52:11Z

Contains two major features, of which the second necessitates the former.

QuestId (which uniquely define a quest's client-side assets, including flags, texts, spawned NPCs, etc) and QuestScheduleId (which is used by the client/server/DB for tracking individual implementations of quests) have been decoupled.
In general, this doesn't require reworking of most systems, with some exceptions:
- If you were attempting to reference a specific quest by scheduleId and previously just casting (uint)QuestId.Foo, you should instead use Server.AssetRepository.QuestScheduleIdAsset[QuestId.Foo] to get the same result.
- If you were doing this without access to the server object (perhaps in a script initialization), you can grab it by static shenanigans, via QuestManager.AssetRepository... Yes, this is cursed.
- If you were previously providing explicit questScheduleIds as part of a quest definition (either json or scripted), you should instead provide a uint variant_index/VariantIndex. For most quests, this is capped at 127 because of janky compression of the existing 32 bit QuestId space into 25 bits.
  - Existing quests q20055001 A Strange Bird Dances in the Forest and q20055004 The Abductors' True Nature have been migrated as an example.
- If you were previously inventing questIds (for world manage purposes), you should provide a scheduleId pattern in the QuestScheduleId.csv asset. These are capped at (15,127,127,127) for the same compression issues. The final column can be used to note the computed scheduleId for later reference, if you think you might want to dig it out of a DB.
As part of this, the DB is migrated to Version 42. Because I am lazy about migration, non-MSQ progress is dropped, as are the quest priority, EXM rank record, and quest reward log tables. Please warn your players that they should collect any outstanding rewards before they get deleted.
Board quests (hunt and delivery) now rotate on a daily basis. Like most things, this occurs at 5 AM JST.
- Boards automatically parse the standard enemy spawn, enemy drop tables, and gathering item assets to attempt to generate quests that are 1) achievable in their region and 2) appropriate level.
- Boards are driven by "generating groups" defined in LightQuests.json.
- Each board attempts to generate 2-5 hunt quests, 2-5 delivery quests, a hunt area order, and a delivery area order, per day. Area Orders request additional kills/items (6-10 vs 2-4) and have correspondingly higher rewards.
- Rewards are controlled by scripts; see light_delivery_quest_reward.csx and light_hunt_quest_reward.csx for examples.
- When boards overlap their sampling region (e.g. Tel and WDT), the "difficulty" is most easily controlled by their bias parameter. When bias_rerolls > 0, that many additional quests are rolled for each slot, and the lowest/highest level quest of that set is taken (direction controlled by bias_lower). Usually Area Orders are biased one step easier to prevent them from being "kill 10 Golems" or something obnoxious.
- If a player holds a board quest past its delivery ending (the next 5 AM rotation), it'll be automatically discarded when they next reset an instance.

Warning

As part of this, the DB is migrated to Version 42. Because I am lazy about migration, non-MSQ progress is dropped, as are the quest priority, EXM rank record, and quest reward log tables. Please warn your players that they should collect any outstanding rewards before they get deleted.

TODO:

Copious amounts of testing.
Adjust some debug commands to not be awful to use with the scheduleId changes.
Figure out the "proper" way to notify a player that quests have been cancelled due to delivery ending.
Fine tuning the quest generation algorithm.
Maybe figure out how the quests-per-day stuff works.
Maybe figure out how the "use GG to finish all the quests on a board" works.
Maybe do Clan Quest rotation and add quests to the second board of clan quests.

Checklist:

The project compiles
The PR targets develop branch

pacampbell · 2025-05-17T15:39:23Z

I wish you had all the deleted files in 1 commit and the changes in another. It is hard to review the thing because my browser is acting poorly with the volume of files changed :(

alborrajo · 2025-05-19T21:53:18Z


-        private static readonly TimeSpan BOARD_QUEST_DURATION = TimeSpan.FromDays(1);
+        // TODO: This should be configurable, but needs to be synced with the reset task or the boards act funny.
+        private static readonly TimeSpan BOARD_QUEST_DURATION = TimeSpan.FromMinutes(2); //TimeSpan.FromDays(1);


2 minutes? development value? 🤔

pacampbell · 2025-05-26T02:44:08Z

                    var questEnemy = new InstancedEnemy()
                    {
-                        EnemyId = Convert.ToUInt32(jEnemy.GetProperty("enemy_id").GetString(), 16),
+                        EnemyId = (EnemyId)Convert.ToUInt32(jEnemy.GetProperty("enemy_id").GetString(), 16),


Wonder if we should make something similar for this like I did for AssetCommonDeserializer.ParseItemId.

pacampbell · 2025-05-26T02:51:46Z

I think you might need to update some of the comments in your PR.

alborrajo · 2025-05-27T15:08:42Z

    private const string DefaultSchemaFile = "Script/schema_sqlite.sql";

-    public const uint Version = 43;
+    public const uint Version = 44;


Same as #856 we have to be careful with the merges

alborrajo · 2025-06-05T15:25:24Z

+        private uint CURRENT_VARIANT_ID = 0;
+
+        // TODO: This should be configurable, but needs to be synced with the reset task or the boards act funny.
+        private static readonly TimeSpan BOARD_QUEST_DURATION = TimeSpan.FromDays(1);


Could this property be read from the task entry in DB? 🤔

Decayed quest cancellation notice on area reset. Clean up EnemyId/EnemyUIId/ClientItemInfos implementation; use ItemId, EnemyId, and EnemyUIId when possible instead of uints Light quest DB stuff, adjustments to handle variant ids, removing decayed quests when returning to town, rotation task and RPC for child servers. Fix some tasks announcing to the non-head servers on the wrong route. Migration 43 -> 44; add support for new quest_id + variant_index scheme for decoupling quest and schedule id. Cleanup inconsistent packet id naming; add some new quest cancellation packets. Light quest generation, mixin for light quest rewards, and asset. Add DeliveryItemsLight and KillTargetEnemies block support to QuestBlockExtension. Add explicit support for DistributionStart/End in the quest asset and quest system. Remove existing board quests.

…hing non-board quests. Adjust migration versioning. Default generators now use all available questIds daily.

… from being considered for generation. Improve rewards for boss hunt quests while reducing their count.

RyanYappert requested review from alborrajo and pacampbell May 14, 2025 07:52

pacampbell reviewed May 15, 2025

View reviewed changes

alborrajo reviewed May 15, 2025

View reviewed changes

alborrajo requested changes May 19, 2025

View reviewed changes

alborrajo mentioned this pull request May 23, 2025

feat: Job Emblems #831

Merged

2 tasks

RyanYappert force-pushed the feat/board_quest_rework branch 2 times, most recently from 9051cf7 to 74e6752 Compare May 26, 2025 01:27

pacampbell approved these changes May 26, 2025

View reviewed changes

RyanYappert force-pushed the feat/board_quest_rework branch from 74e6752 to 0442f60 Compare May 26, 2025 07:16

pacampbell requested a review from alborrajo May 26, 2025 19:25

RyanYappert force-pushed the feat/board_quest_rework branch from 0442f60 to cc0dc17 Compare May 26, 2025 19:38

RyanYappert mentioned this pull request May 27, 2025

Clan Requests #856

Open

2 tasks

alborrajo approved these changes May 27, 2025

View reviewed changes

RyanYappert force-pushed the feat/board_quest_rework branch from cc0dc17 to ab404a4 Compare June 1, 2025 06:19

alborrajo approved these changes Jun 5, 2025

View reviewed changes

RyanYappert added 4 commits June 6, 2025 20:50

Adjust migration.

8f0923a

Fix hunt quests not restoring progress properly. Fix quest decay catc…

81b3899

…hing non-board quests. Adjust migration versioning. Default generators now use all available questIds daily.

Tweak distribution for quest generation; block event Hidell Catacombs…

d2b9f7f

… from being considered for generation. Improve rewards for boss hunt quests while reducing their count.

RyanYappert force-pushed the feat/board_quest_rework branch from ab404a4 to d2b9f7f Compare June 7, 2025 03:57

RyanYappert merged commit 73b85a3 into sebastian-heinz:develop Jun 7, 2025
1 check passed

Conversation

RyanYappert commented May 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TODO:

Checklist:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pacampbell commented May 17, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alborrajo May 19, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pacampbell May 26, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pacampbell commented May 26, 2025

Uh oh!

alborrajo May 27, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

alborrajo Jun 5, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

RyanYappert commented May 14, 2025 •

edited

Loading