Skip to content

Feature: GP Shop PR Cleanup#724

Open
RyanYappert wants to merge 6 commits into
sebastian-heinz:developfrom
RyanYappert:feature/gp-shop
Open

Feature: GP Shop PR Cleanup#724
RyanYappert wants to merge 6 commits into
sebastian-heinz:developfrom
RyanYappert:feature/gp-shop

Conversation

@RyanYappert

Copy link
Copy Markdown
Collaborator

Cleans up and preps the existing GP shop code from @Sehkah and @pacampbell for merging.

  • Ensures constructors and serializers properly instantiate their members and strings.
  • Removes raw references to localhost and constructs the necessary paths from the game settings.
  • Removes possibly copyrighted material from the repository. This should be archived separately for legal reasons.

Since some of these handlers are still in a very early state and expose hardcoded functionality, they've been blocked off from players with a ResponseErrorException.

Checklist:

  • The project compiles
  • The PR targets develop branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants