Disable index-related tests for Object Storage that were missed in the backport of #3503#3533
Merged
Merged
Conversation
…e backport of #3503 Object Storage does not support secondary indexes, so index-based tests are overridden with @disabled in ConsensusCommitSpecificIntegrationTestWithObjectStorage. The backport of #3503 added three new index-based tests to the base class but missed adding the corresponding @disabled overrides, causing the Object Storage integration test job to fail on 3.17 with IllegalArgumentException from OperationChecker (OPERATION_CHECK_ERROR_INDEX_NON_INDEXED_COLUMN_SPECIFIED). This adds the three missing overrides, matching the contents already present on master.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the ConsensusCommitSpecificIntegrationTestWithObjectStorage class by overriding and disabling three integration tests related to index operations, as Object Storage does not support them. I have no feedback to provide.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the 3.17 backport gap where newly added index-based integration tests were not disabled for the Object Storage backend, which does not support secondary index operations.
Changes:
- Added three method overrides in
ConsensusCommitSpecificIntegrationTestWithObjectStorageannotated with@Disabledto prevent index-based tests from running on Object Storage. - Aligns 3.17 behavior with
master, avoiding CI failures caused by index operation checks.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The backport #3503 (which backported #3488 to the 3.17 branch) added three new index-based tests to
ConsensusCommitSpecificIntegrationTestBase. Object Storage does not support secondary indexes, so all index-based tests inConsensusCommitSpecificIntegrationTestWithObjectStorageare overridden with@Disabled("Object Storage does not support index-related operations"). However, the 3.17 backport missed adding the corresponding@Disabledoverrides for the three new tests, which caused the Object Storage integration test job to fail withIllegalArgumentExceptionfromOperationChecker(OPERATION_CHECK_ERROR_INDEX_NON_INDEXED_COLUMN_SPECIFIED) on 3 isolation levels each (9 failures total) across all Java versions in the 3.17 CI run.The override block already exists on
master; this PR brings it over to 3.17.Reference failed run: https://github.com/scalar-labs/scalardb/actions/runs/24931966290
Related issues and/or PRs
Changes made
@Disabledoverrides inConsensusCommitSpecificIntegrationTestWithObjectStoragefor the following tests, matching the contents already present onmaster:get_GetWithIndexForPreparedWhenCoordinatorStateAbortedAndIndexKeyMatchesAfterImage_ShouldRollBackAndFilterOutResultscan_ScanWithIndexForPreparedWhenCoordinatorStateAbortedAndIndexKeyMatchesAfterImage_ShouldRollBackAndFilterOutResultgetScanner_ScanWithIndexForPreparedWhenCoordinatorStateAbortedAndIndexKeyMatchesAfterImage_ShouldRollBackAndFilterOutResultChecklist
Additional notes (optional)
This is a 3.17-only fix;
masteralready contains the equivalent overrides, so no forward-port is needed. The 3.16 branch does not have Object Storage support and is unaffected.Release notes
N/A