Backport to branch(3) : Fix index-based Get/Scan to filter out results whose index key no longer matches after lazy recovery rollback#3505
Merged
Conversation
…ger matches after lazy recovery rollback (#3488)
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements index key filtering after lazy recovery in the Consensus Commit protocol to ensure that rolled-back records with non-matching index values are correctly excluded from results and not incorrectly cached as absent in the snapshot. The changes span CrudHandler and include extensive testing. The reviewer suggested simplifying the conditional logic in read and processScanResult for better readability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated backport of the following:
Please merge this PR after all checks have passed.