Backport to branch(3.16) : Fix index-based Get/Scan to filter out results whose index key no longer matches after lazy recovery rollback#3504
Merged
Conversation
…ger matches after lazy recovery rollback (#3488)
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a fix for secondary index lookups within the consensus commit protocol. It addresses a specific edge case where a record retrieved via a secondary index is rolled back during lazy recovery, resulting in an index column value that no longer matches the queried key. The changes ensure these records are correctly filtered out of the final result set and prevent incorrect 'absent' results from being cached in the transaction snapshot. Comprehensive unit and integration tests have been added to verify the filtering logic across read and scan operations. I have no feedback to provide as there were no review comments to assess.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated backport of the following:
Please merge this PR after all checks have passed.