fix: skip opendal TimeoutLayer under madsim#160
Merged
Conversation
Signed-off-by: Mingzhuo Yin <yinmingzhuo@gmail.com>
silver-ymz
requested review from
Li0k,
chenzl25,
jonathanc-n,
mwylde and
nagraham
as code owners
chenzl25
approved these changes
May 21, 2026
chenzl25
left a comment
chenzl25
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. FYI, Madsim is a deterministic test framework used by RisingWave.
amitgilad3
pushed a commit
to lakeops-org/iceberg-rust-risingwave
that referenced
this pull request
Jun 4, 2026
Signed-off-by: Mingzhuo Yin <yinmingzhuo@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
Opendal's TimeoutLayer relies on real
tokio::time::timeout, which is not provided by the madsim runtime and triggers "no reactor running" panics during simulated tests.