Skip to content

ci: add placeholder required status gate#6

Merged
WomB0ComB0 merged 3 commits into
mainfrom
feat/ci-governance-adoption
Apr 17, 2026
Merged

ci: add placeholder required status gate#6
WomB0ComB0 merged 3 commits into
mainfrom
feat/ci-governance-adoption

Conversation

@WomB0ComB0

Copy link
Copy Markdown
Member

Summary

Adds .github/workflows/required.yml alongside existing CI. Placeholder that emits a green required status-check context matched by org ruleset default-branch-baseline (id 15191038, evaluate mode). Existing CI workflows continue to run independently.

Before flipping the ruleset to active, either add needs: on this repo's existing CI jobs in required.yml, or replace with a reusable-workflow call from resq-software/.github.

Related: resq-software/.github#12.

Satisfies the `required` status-check context in org ruleset
`default-branch-baseline` (id 15191038, evaluate mode). Placeholder
that always passes; this repo'\''s existing CI workflows continue to
run independently.

Before the ruleset flips to active, harden this job with `needs:`
on the existing CI jobs — or swap for a call to a reusable workflow
in resq-software/.github.
@gemini-code-assist

Copy link
Copy Markdown

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@coderabbitai

coderabbitai Bot commented Apr 17, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@WomB0ComB0 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 54 minutes and 52 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 54 minutes and 52 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7be41e7e-6ca4-44fb-8600-76036538739a

📥 Commits

Reviewing files that changed from the base of the PR and between bc6fbbb and a86687d.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/ci-governance-adoption

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

WomB0ComB0 added a commit to resq-software/.github that referenced this pull request Apr 17, 2026
…l dispatch

Adds the two deferred reusable workflows:

- dotnet-ci.yml: restore, build, format check, test. Configurable
  dotnet-version (default 9.0.x), solution path, working-directory.
- cpp-ci.yml: CMake configure + build + test matrix across
  ubuntu/macos/windows (configurable). Harden-runner on Linux only
  (step-security action is Linux-native).

Extends required.yml to dispatch the two new languages, and adds
proto handling (security-only, no language build dispatched). New
inputs: dotnet-version, dotnet-solution, cpp-os-list, cpp-source-dir,
cpp-cmake-flags.

After this lands, these placeholder consumer PRs can be hardened to
call real CI:
- resq-software/dotnet-sdk#36 (dotnet)
- resq-software/viz#4 (dotnet)
- resq-software/vcpkg#6 (cpp)
- resq-software/ardupilot#1 (cpp)
Replaces the previous inline cmake/ctest matrix and the placeholder
required.yml with a single ci.yml that calls the org-wide `required`
aggregator with `lang: cpp` and the correct source-dir +
cmake-flags preserved from the prior workflow.

Pinned to resq-software/.github@6410acb (the commit introducing
cpp-ci.yml). Re-pin to the merge commit or tag after PR#12 lands.

Parity:
- os matrix: ubuntu + macos + windows (same as before)
- source: packages/resq-common (same)
- flag:   -DRESQ_COMMON_BUILD_TESTS=ON (same)

Additionally runs CodeQL for c-cpp and the full security-scan
suite via the reusable — upgrade from the prior CI.
Updates @sha from the feat-branch tip to the merge commit of
resq-software/.github#12 (f4b51a620aa1bf89c0bce4f434b36f92ff7d517d). Functionally equivalent — same
content — but pins to a ref that now exists on main rather than a
closed PR branch.
@WomB0ComB0
WomB0ComB0 merged commit 9fa81af into main Apr 17, 2026
31 of 34 checks passed
@WomB0ComB0
WomB0ComB0 deleted the feat/ci-governance-adoption branch April 17, 2026 10:18
WomB0ComB0 added a commit that referenced this pull request Jun 12, 2026
* fix(security): resolve CodeQL/zizmor code-scanning alerts

- env_utils: replace fragile `find(...) != 0` scheme check with the
  anchored `rfind(prefix, 0) == 0` idiom in validate_url_env (hardens
  the prefix match; CodeQL #1 is a false positive — env-var config
  validation, not an authentication barrier — dismissed separately).
- ci.yml: drop workflow-level `security-events: write`; grant it only to
  the `gates` job that runs CodeQL (zizmor excessive-permissions #7).
- security.yml: pin the org reusable security-scan.yml to a commit SHA
  (zizmor unpinned-uses #5), matching ci.yml's existing convention.
- add .github/zizmor.yml documenting intentional ignores: secrets-inherit
  on first-party org reusable callers (#6, #8) and template-injection in
  gh-aw generated workflow files (#11-20, DO NOT EDIT / maintainer vars).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* refactor(env_utils): use strncmp for allocation-free scheme check

Address review feedback: check the http(s):// prefix directly on the
const char* with std::strncmp instead of constructing a std::string,
avoiding an unnecessary heap allocation. strncmp stops at the NUL
terminator, so short values remain safe.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant