fix: prevent multiple simultaneous sound plays#83
Open
chabou wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was experimenting with some features and ran into an issue.
Currently, every sound is played multiple times simultaneously.
I added this log in the
use-soundcustom hook:And with a single sound selected, this was the output:

After some digging, I found that sound.playing() is not reliable when sound.play() is called multiple times within a short timeframe.
This is because there’s a small delay before the sound state changes, due to asynchronous operations (queued actions).
The solution I found is to track this state manually on our side, to prevent additional sound.play() calls.
This bug is not noticeable to the user, but it makes things more complicated when trying to implement new sound-level features.