fix: support portrait/vertical app screenshots across viewer and cards#76
Open
hbnordin2 wants to merge 1 commit into
Open
fix: support portrait/vertical app screenshots across viewer and cards#76hbnordin2 wants to merge 1 commit into
hbnordin2 wants to merge 1 commit into
Conversation
Portrait images were rendered poorly: the viewer showed them at full width causing excessive vertical overflow, TwoUp and Diff views had no height constraints, and card thumbnails showed tiny slivers due to scale-down fit. - useComparisonImage: constrain by viewport height so portrait images fit without scrolling (affects Slide, Blend, Toggle modes) - TwoUp: cap image max-height to viewport via globalStyle - Diff: wrap in flex container with matching max-height constraint - Card: switch from scale-down to cover so portrait thumbnails fill the card area meaningfully Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Portrait images were rendered poorly: the viewer showed them at full width causing excessive vertical overflow, TwoUp and Diff views had no height constraints, and card thumbnails showed tiny slivers due to scale-down fit.
What does this change?
A clear and concise description of what the changes is.
References
Screenshots
If applicable, add screenshots to help explain your changes.
What can I check for bug fixes?
Please briefly describe how you can confirm the resolution of the bug.