#1280 error handling improvements#1299
Draft
djdanielsson wants to merge 8 commits into
Draft
Conversation
Collaborator
Author
|
I have not tested this yet, wanted to see what people thought of it because it was generated. I will try and test it in the next few days. |
Collaborator
|
In a quick look there are some questions I have about new variables that have been introduced, but I haven't gone through the changes in detail. I'll let you get some testing done before I do an in-depth review. |
Collaborator
Author
|
ok this one is tested and works but still not sure i love it, would like to see what others think of it |
Collaborator
|
@djdanielsson As you know I'm lazy. I trust it works. But can you provide a sample output of what we will see with this change? |
djdanielsson
temporarily deployed
to
requires-approval
GitHub Actions
Inactive
…ist, defaulting to [collect_async_status.yml, handle_error.yml] — register removed from default path to reduce output collect_async_status.yml (new): Extracted async polling; uses failed_when gated by cas_collect_logs instead of ignore_errors: true register_value.yml (new): Extracted value registration; self-guarded, opt-in via cas_task_files handle_error.yml: Added self-guard (when: result is defined and failed), added no_log, switched from aap_configuration_collect_logs to cas_collect_logs, added API response detail and status code to error output defaults/main.yml: Added cas_collect_logs (falls back to aap_configuration_collect_logs, default false) README.md: Documented composable task files, cas_task_files, cas_collect_logs, error output fields tests/: Replaced ignore_errors: true with failed_when: false
djdanielsson
force-pushed
the
error_handling
branch
from
fc24e0b to
7c33a5d
Compare
djdanielsson
temporarily deployed
to
requires-approval
GitHub Actions
Inactive
…factor Apply the same msg/detail/error lookup chain from redhat-cop#1305 to the refactored handle_error.yml so modules that put errors in detail or error keys still produce useful messages when redhat-cop#1299 merges. Co-authored-by: Cursor <cursoragent@cursor.com>
djdanielsson
temporarily deployed
to
requires-approval
GitHub Actions
Inactive
djdanielsson
temporarily deployed
to
requires-approval
GitHub Actions
Inactive
ansible-core devel now requires Python >=3.13, so the py3.12-devel tox environment cannot install dependencies and fails during CI setup. Co-authored-by: Cursor <cursoragent@cursor.com>
djdanielsson
temporarily deployed
to
requires-approval
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this was Claude-4.6-opus solution for #1280 figured I would throw it in there while also making some tweaks to fix the error handling issue that #1295 showed it didn't account for.