Skip to content

feat(info): display workflow image vetting settings #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tiborsimko merged 2 commits into from
Jun 7, 2026
Merged

feat(info): display workflow image vetting settings #182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df5316c
feat(info): display workflow image vetting settings (#182)
CameronMcClymont Jun 5, 2026
ee4735b
build(go): upgrade to Go 1.25.11 (#182)
CameronMcClymont Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
- name: Setup Go
uses: actions/setup-go@v5
with:
go-version: "1.25.10"
go-version: "1.25.11"

- name: Check shell completions are up-to-date
run: ./run-tests.sh --shell-completions
Expand All @@ -32,7 +32,7 @@ jobs:
- name: Setup Go
uses: actions/setup-go@v5
with:
go-version: "1.25.10"
go-version: "1.25.11"

- name: Check Go code formatting
run: ./run-tests.sh --format-go
Expand Down Expand Up @@ -71,7 +71,7 @@ jobs:
- name: Setup Go
uses: actions/setup-go@v5
with:
go-version: "1.25.10"
go-version: "1.25.11"

- name: Run Go test suite
run: ./run-tests.sh --go-tests
Expand Down Expand Up @@ -116,7 +116,7 @@ jobs:
- name: Setup Go
uses: actions/setup-go@v5
with:
go-version: "1.25.10"
go-version: "1.25.11"

- name: Run Go audit checks
run: ./run-tests.sh --lint-goaudit
Expand Down
2 changes: 1 addition & 1 deletion .mise.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
[tools]
go = "1.25.10"
go = "1.25.11"
200 changes: 200 additions & 0 deletions client/operations/info_responses.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions cmd/info.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,16 @@ func (o *infoOptions) run(cmd *cobra.Command) error {
if p.SupportedWorkflowEngines != nil {
displayInfoSliceItem(cmd, p.SupportedWorkflowEngines.Title, p.SupportedWorkflowEngines.Value)
}
if p.VettedContainerImagesAllowlist != nil {
displayInfoSliceItem(cmd, p.VettedContainerImagesAllowlist.Title, p.VettedContainerImagesAllowlist.Value)
}
if p.VettedContainerImagesEnabled != nil {
value := "False"
if p.VettedContainerImagesEnabled.Value {
value = "True"
}
cmd.Printf("%s: %s\n", p.VettedContainerImagesEnabled.Title, value)

@tiborsimko tiborsimko Jun 5, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Could add a false-valued fixture for vetted_container_images_enabled (NIT)

The current info fixture covers the True output. Since this is the first boolean-valued /info field handled by a one-off formatter, it would be useful to also assert the False rendering, e.g. in the missing-fields/small fixture or a tiny dedicated case.

Suggested fix — extend testdata/inputs/info_small.json with "vetted_container_images_enabled": {"value": false, "title": "Whether container image vetting is enabled"} and add "Whether container image vetting is enabled: False" to the missing fields expectations in cmd/info_test.go.

@tiborsimko tiborsimko Jun 5, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 /info now mixes real booleans with string-encoded booleans (NIT, server-side)

vetted_container_images_enabled.value is a JSON boolean, while older toggles such as dask_enabled and interactive_sessions_custom_image_allowed remain "True"/"False" strings. The Go client handles this correctly here (hence the manual True/False conversion above), but it may be worth deciding on one convention for future /info fields.

Suggested fix — raise on reanahub/reana-server#739 (e.g. converge older toggles on BooleanInfoValue, or document the rationale). No change needed in this Go client PR.

}
if p.WorkspacesAvailable != nil {
displayInfoSliceItem(cmd, p.WorkspacesAvailable.Title, p.WorkspacesAvailable.Value)
}
Expand Down
4 changes: 4 additions & 0 deletions cmd/info_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@ func TestInfo(t *testing.T) {
"Users can set custom interactive session images: False",
"Recommended jupyter images for interactive sessions: docker.io/jupyter/scipy-notebook:notebook-6.4.5",
"List of supported workflow engines: cwl, serial, snakemake, yadage",
"List of vetted container images allowed in user workflows: docker.io/library/python:2.7-slim, docker.io/reanahub/reana-env-root6:6.18.04",
"Vetted container images required for user workflows: True",
"CWL engine tool: cwltool",
"CWL engine version: 3.1.20210628163208",
"Yadage engine version: 0.20.1",
Expand Down Expand Up @@ -89,6 +91,8 @@ func TestInfo(t *testing.T) {
"\"interactive_sessions_custom_image_allowed\": {", "\"value\": \"False\"",
"\"interactive_session_recommended_jupyter_images\": {", "\"value\": [", "\"docker.io/jupyter/scipy-notebook:notebook-6.4.5\"",
"\"supported_workflow_engines\": {", "\"value\": [", "\"cwl\",", "\"serial\",", "\"snakemake\",", "\"yadage\"",
"\"vetted_container_images_allowlist\": {", "\"docker.io/library/python:2.7-slim\"",
"\"vetted_container_images_enabled\": {", "\"value\": true",
"\"cwl_engine_tool\": {", "\"value\": \"cwltool\"",
"\"cwl_engine_version\": {", "\"value\": \"3.1.20210628163208\"",
"\"yadage_engine_version\": {", "\"value\": \"0.20.1\"",
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module reanahub/reana-client-go

go 1.25.10
go 1.25.11

require (
github.com/go-gota/gota v0.12.0
Expand Down
11 changes: 11 additions & 0 deletions testdata/inputs/info_big.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,5 +106,16 @@
"dask_enabled": {
"title": "Dask workflows allowed in the cluster",
"value": "False"
},
"vetted_container_images_allowlist": {
"title": "List of vetted container images allowed in user workflows",
"value": [
"docker.io/library/python:2.7-slim",
"docker.io/reanahub/reana-env-root6:6.18.04"
]
},
"vetted_container_images_enabled": {
"title": "Vetted container images required for user workflows",
"value": true
}
}
Loading