BUG: fixes MAFFT failing tests#96
Merged
Merged
Conversation
Member
|
Thanks for providing all of these details @cherman2, these changes lgtm! |
lizgehret
approved these changes
Mar 19, 2026
github-project-automation
Bot
moved this from Needs Review
to Ready for Merge
in 2026.4 🌱
github-project-automation
Bot
moved this from Ready for Merge
to Changelog Needed
in 2026.4 🌱
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses failing tests in q2-alignment.
According to this PR: scikit-bio/scikit-bio#2320, Most MSA formats (?) populate the index of the structure using sequence metadata, except FASTQ and FASTA. This was changed in 0.7.1 of Skbio: https://github.com/scikit-bio/scikit-bio/blob/main/CHANGELOG.md
Our tests assumed an automatically generated pandas dataframe index like this: pd.RangeIndex(start=0, stop=len(sequences), step=1).
To fix this, I added indexes to our constructors and now all the tests pass locally for me.