This repository was archived by the owner on Jun 11, 2026. It is now read-only.
Add semantically scoped vm#23
Merged
Merged
Conversation
Signed-off-by: Jonathan Lim <jonathan.lim.222@gmail.com>
Signed-off-by: Jonathan Lim <jonathan.lim.222@gmail.com>
Signed-off-by: Jonathan Lim <jonathan.lim.222@gmail.com>
jonathanlim222
changed the title
Signed-off-by: Jonathan Lim <jonathan.lim.222@gmail.com>
Signed-off-by: Jonathan Lim <jonathan.lim.222@gmail.com>
Signed-off-by: Jonathan Lim <jonathan.lim.222@gmail.com>
Signed-off-by: Jonathan Lim <jonathan.lim.222@gmail.com>
yHSJ
reviewed
Nov 5, 2025
yHSJ
left a comment
yHSJ
left a comment
Contributor
There was a problem hiding this comment.
I think I like this a lot more. I gave it a rather brief review, I'll dig more in depth later if I have time (I am also struggling a bit with the new files changed view, which seems to handle files individually when there are lots of changes), so I'm not sure if I missed anything.
I love knowing that we will not be panicking when running a program with unsupported functions in it based on the plutus version. I think the biggest thing I'd think about for now is to use a trait instead of an enum with variants for each version. But, this is looking a lot better and I'd be willing to say that we can focus on "cleanup and improvement" in a future iteration.
Signed-off-by: Jonathan Lim <jonathan.lim.222@gmail.com>
Signed-off-by: yHSJ <josh@securitybot.info>
Quantumplation
pushed a commit
that referenced
this pull request
Mar 15, 2026
Add semantically scoped vm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds initializing the cost model from the incoming protocol params.