This repository was archived by the owner on Jun 11, 2026. It is now read-only.
fix: do not allow the use of - in names#21
Closed
etorreborre wants to merge 2 commits into
Closed
Conversation
Signed-off-by: etorreborre <etorreborre@yahoo.com>
etorreborre
force-pushed
the
etorreborre/fix
branch
from
668ac07 to
1704381
Compare
Signed-off-by: etorreborre <etorreborre@yahoo.com>
|
In fact, this is a mistake in the spec, and I believe we've raised an issue to have the spec updated 😅 |
|
At least I thought we had, but I can't find it now. |
Author
|
Ok, good to know. Closing this PR then. |
Contributor
Yes, we did. It's here, in the Cardano scaling Discord: https://discord.com/channels/981862537513545788/1333746155083006037/1398426636692488232. I will open an issue on the plutus repo, I totally forgot about that actually |
|
@yHSJ please link the issue here when you do, for future googling efforts |
Contributor
|
Created an issue for it: IntersectMBO/plutus#7365 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was casually reading this code and it seems to me that a
-should not be allowed in names. Only_can be used as a separator (the comment on the function is correctly aligned with the spec).