Skip to content

Incorporate changes from New Streaming Player #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
briankeane merged 15 commits into from
Mar 21, 2026
Merged

Incorporate changes from New Streaming Player #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
f2ac0e3
Merge pull request #50 from playola-radio/develop
briankeane Aug 19, 2025
c612497
Merge pull request #52 from playola-radio/develop
briankeane Aug 29, 2025
2b9512c
Merge pull request #55 from playola-radio/develop
briankeane Aug 31, 2025
ebe267b
Merge pull request #59 from playola-radio/develop
briankeane Sep 5, 2025
dcbf07c
Merge pull request #62 from playola-radio/develop
briankeane Sep 9, 2025
beee655
Merge pull request #64 from playola-radio/develop
briankeane Sep 13, 2025
dc60019
Merge pull request #80 from playola-radio/develop
briankeane Feb 14, 2026
b185747
Add AVPlayer-based streaming player for faster audio startup
briankeane Mar 20, 2026
b2e77e0
Add streaming/download toggle to example app and fix station switching
briankeane Mar 21, 2026
c54dc5e
Fix SwiftLint violations: large tuple and for-where
briankeane Mar 21, 2026
4658b78
Fix concurrency bugs, memory leak, and race conditions from review
briankeane Mar 21, 2026
5284796
Fix review round 2: idle state, @StateObject, overlapping fades
briankeane Mar 21, 2026
98c58cf
Guard against stop() during loadAndPlaySpin await
briankeane Mar 21, 2026
03e2ce3
Add PR review comment reaction guideline to CLAUDE.md
briankeane Mar 21, 2026
b2f872f
Merge pull request #82 from playola-radio/briankeane/streaming-player
briankeane Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,8 @@
## Type Usage
- Model types should conform to Codable, Sendable, Equatable & Hashable
- Use strong typing and avoid optionals where possible
- Use proper access control (public, internal, private)
- Use proper access control (public, internal, private)

## PR Review Comments
- After addressing a PR review comment, add a 👍 reaction to it via `gh api /repos/{owner}/{repo}/pulls/comments/{id}/reactions -f content='+1'`
- For PR-level comments, use `gh api /repos/{owner}/{repo}/issues/comments/{id}/reactions -f content='+1'`
Loading
Loading