Skip to content

Expose ICE use-candidate priority setting#3449

Open
ziollek wants to merge 2 commits into
pion:mainfrom
anam-org:anam/expose-ice-use-candidate-check-priority
Open

Expose ICE use-candidate priority setting#3449
ziollek wants to merge 2 commits into
pion:mainfrom
anam-org:anam/expose-ice-use-candidate-check-priority

Conversation

@ziollek

@ziollek ziollek commented Jun 15, 2026

Copy link
Copy Markdown

Description

Expose SettingEngine.SetICEUseCandidateCheckPriority so applications can enable ICE use-candidate check priority handling in the underlying ICE agent.

For ICE Lite deployments, enforcing candidate-pair priorities before honoring USE-CANDIDATE allows applications to work around Firefox selecting a lower-priority pair: https://bugzilla.mozilla.org/show_bug.cgi?id=1034964

Reference issue

N/A - external Firefox Bugzilla issue above.

Signed-off-by: Tomasz Ziółkowski <tomasz@anam.ai>
@codecov

codecov Bot commented Jun 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.48%. Comparing base (7306350) to head (3888b6b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3449      +/-   ##
==========================================
- Coverage   85.54%   85.48%   -0.06%     
==========================================
  Files          81       81              
  Lines        9857     9862       +5     
==========================================
- Hits         8432     8431       -1     
- Misses       1007     1010       +3     
- Partials      418      421       +3     
Flag Coverage Δ
go 85.48% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ziollek

ziollek commented Jun 24, 2026

Copy link
Copy Markdown
Author

@JoTurk could any maintainer take a look?

@JoTurk

JoTurk commented Jun 24, 2026

Copy link
Copy Markdown
Member

@ziollek thank you, I'll try to take a look tonight.

@JoTurk JoTurk self-requested a review June 24, 2026 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants