Add failing test for stopped transceivers#2274
Open
k0nserv wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2274 +/- ##
==========================================
+ Coverage 84.08% 84.15% +0.06%
==========================================
Files 80 80
Lines 9068 9068
==========================================
+ Hits 7625 7631 +6
+ Misses 1021 1018 -3
+ Partials 422 419 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4d16d78 to
67eac48
Compare
Member
|
@k0nserv sorry that your PR got ghosted, I'll try to get this behavior and your commit for pion@4.3.0, thank you. |
Author
|
I'm not fussed personally (I don't use Pion). I recall @Sean-Der and I discussed this on Slack when I raised this PR, but really it's pretty big change in behaviour that needs to be considered carefully |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A small failing test were upon stopping a transceiver it is not rejected in the following offer.