Skip to content

Add failing test for stopped transceivers#2274

Open
k0nserv wants to merge 1 commit into
pion:mainfrom
k0nserv:chore/add-failing-transceiver-stop-test
Open

Add failing test for stopped transceivers#2274
k0nserv wants to merge 1 commit into
pion:mainfrom
k0nserv:chore/add-failing-transceiver-stop-test

Conversation

@k0nserv

@k0nserv k0nserv commented Jul 7, 2022

Copy link
Copy Markdown

Description

A small failing test were upon stopping a transceiver it is not rejected in the following offer.

@codecov

codecov Bot commented Jul 7, 2022

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.15%. Comparing base (5552def) to head (67eac48).
⚠️ Report is 113 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2274      +/-   ##
==========================================
+ Coverage   84.08%   84.15%   +0.06%     
==========================================
  Files          80       80              
  Lines        9068     9068              
==========================================
+ Hits         7625     7631       +6     
+ Misses       1021     1018       -3     
+ Partials      422      419       -3     
Flag Coverage Δ
go 84.15% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JoTurk JoTurk force-pushed the chore/add-failing-transceiver-stop-test branch from 4d16d78 to 67eac48 Compare November 24, 2025 09:52
@k0nserv k0nserv closed this May 18, 2026
@JoTurk

JoTurk commented May 18, 2026

Copy link
Copy Markdown
Member

@k0nserv sorry that your PR got ghosted, I'll try to get this behavior and your commit for pion@4.3.0, thank you.

@JoTurk JoTurk reopened this May 18, 2026
@JoTurk JoTurk added this to the v4.3.0 milestone May 18, 2026
@k0nserv

k0nserv commented May 18, 2026

Copy link
Copy Markdown
Author

I'm not fussed personally (I don't use Pion). I recall @Sean-Der and I discussed this on Slack when I raised this PR, but really it's pretty big change in behaviour that needs to be considered carefully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants