Skip to content

fix(OutlinedClockIcon): Replace OutlinedClockIcon with RhUiClockIcon#12465

Merged
nicolethoen merged 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-outlined-clock-icon-with-rh-ui-clock
Jun 17, 2026
Merged

fix(OutlinedClockIcon): Replace OutlinedClockIcon with RhUiClockIcon#12465
nicolethoen merged 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-outlined-clock-icon-with-rh-ui-clock

Conversation

@rebeccaalpert

@rebeccaalpert rebeccaalpert commented Jun 12, 2026

Copy link
Copy Markdown
Member

What:
This is one piece of #12400. Breaking it up by icon so it is easier to review.

Additional issues:

Summary by CodeRabbit

  • Style
    • Updated the clock icon used in the TimePicker and DateTimePicker to improve visual consistency.
    • Refreshed the DateTimePicker demo and documentation to match the new clock icon styling.

@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b53bcfdf-7ffd-404a-8270-40044e6eee08

📥 Commits

Reviewing files that changed from the base of the PR and between 2e12821 and 6ae360d.

📒 Files selected for processing (3)
  • packages/react-core/src/components/TimePicker/TimePicker.tsx
  • packages/react-core/src/demos/DateTimePicker.md
  • packages/react-core/src/demos/examples/DateTimePicker/DateTimePicker.tsx
✅ Files skipped from review due to trivial changes (2)
  • packages/react-core/src/demos/DateTimePicker.md
  • packages/react-core/src/components/TimePicker/TimePicker.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/react-core/src/demos/examples/DateTimePicker/DateTimePicker.tsx

Walkthrough

This PR replaces OutlinedClockIcon with RhUiClockIcon across the TimePicker component and its demo examples. The icon imports and component prop assignments are updated in both the core component and demo documentation to use the new icon.

Changes

Clock icon replacement

Layer / File(s) Summary
TimePicker component icon update
packages/react-core/src/components/TimePicker/TimePicker.tsx
The TimePicker component import statement replaces OutlinedClockIcon with RhUiClockIcon, and the TextInput customIcon prop is updated to render the new icon.
Demo and documentation icon updates
packages/react-core/src/demos/examples/DateTimePicker/DateTimePicker.tsx, packages/react-core/src/demos/DateTimePicker.md
The DateTimePicker demo example and documentation are updated to import RhUiClockIcon instead of OutlinedClockIcon, and the MenuToggle icon prop is changed to use the new icon.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • kmcfaul
  • thatblindgeye
  • nicolethoen
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and accurately describes the main change: replacing OutlinedClockIcon with RhUiClockIcon across multiple components and documentation files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@patternfly-build

patternfly-build commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

@rebeccaalpert rebeccaalpert force-pushed the cursor/replace-outlined-clock-icon-with-rh-ui-clock branch from dbc6a91 to 2e12821 Compare June 12, 2026 18:25
@rebeccaalpert rebeccaalpert marked this pull request as draft June 15, 2026 15:30
@rebeccaalpert rebeccaalpert marked this pull request as ready for review June 15, 2026 15:31
Co-authored-by: Cursor <cursoragent@cursor.com>
@rebeccaalpert rebeccaalpert force-pushed the cursor/replace-outlined-clock-icon-with-rh-ui-clock branch from 2e12821 to 6ae360d Compare June 17, 2026 17:38
@nicolethoen nicolethoen merged commit cbdab57 into patternfly:main Jun 17, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants