Skip to content

Fix operator precedence bug in getRefByUuid() exception message #6351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kapil-kundu wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix operator precedence bug in getRefByUuid() exception message #6351

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d1588a
TRUNK-6714
Kapil-kundu Jul 18, 2026
97c8e9b
Add test coverage for null type in getRefByUuid
Kapil-kundu Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/src/main/java/org/openmrs/api/impl/ObsServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -679,7 +679,7 @@ public <T> T getRefByUuid(Class<T> type, String uuid) {
if (Obs.class.equals(type)) {
return (T) getObsByUuid(uuid);
}
throw new APIException("Unsupported type for getRefByUuid: " + type != null ? type.getName() : "null");
throw new APIException("Unsupported type for getRefByUuid: " + (type != null ? type.getName() : "null"));
}

@Override
Expand Down
2 changes: 1 addition & 1 deletion api/src/main/java/org/openmrs/api/impl/OrderServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1386,7 +1386,7 @@ public <T> T getRefByUuid(Class<T> type, String uuid) {
if (OrderGroupAttributeType.class.equals(type)) {
return (T) getOrderGroupAttributeTypeByUuid(uuid);
}
throw new APIException("Unsupported type for getRefByUuid: " + type != null ? type.getName() : "null");
throw new APIException("Unsupported type for getRefByUuid: " + (type != null ? type.getName() : "null"));
}

@Override
Expand Down
2 changes: 1 addition & 1 deletion api/src/main/java/org/openmrs/api/impl/PersonServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1031,7 +1031,7 @@ public <T> T getRefByUuid(Class<T> type, String uuid) {
if (PersonAddress.class.equals(type)) {
return (T) getPersonAddressByUuid(uuid);
}
throw new APIException("Unsupported type for getRefByUuid: " + type != null ? type.getName() : "null");
throw new APIException("Unsupported type for getRefByUuid: " + (type != null ? type.getName() : "null"));
}

@Override
Expand Down
2 changes: 1 addition & 1 deletion api/src/main/java/org/openmrs/api/impl/UserServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -833,7 +833,7 @@ public <T> T getRefByUuid(Class<T> type, String uuid) {
if (User.class.equals(type)) {
return (T) getUserByUuid(uuid);
}
throw new APIException("Unsupported type for getRefByUuid: " + type != null ? type.getName() : "null");
throw new APIException("Unsupported type for getRefByUuid: " + (type != null ? type.getName() : "null"));
}

@Override
Expand Down
2 changes: 1 addition & 1 deletion api/src/main/java/org/openmrs/api/impl/VisitServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,7 +439,7 @@ public <T> T getRefByUuid(Class<T> type, String uuid) {
if (VisitAttributeType.class.equals(type)) {
return (T) getVisitAttributeTypeByUuid(uuid);
}
throw new APIException("Unsupported type for getRefByUuid: " + type != null ? type.getName() : "null");
throw new APIException("Unsupported type for getRefByUuid: " + (type != null ? type.getName() : "null"));
}

@Override
Expand Down