Fix operator precedence bug in getRefByUuid() exception message

[Kapil-kundu]

The getRefByUuid() method contains an operator precedence issue in the APIException message construction:

throw new APIException("Unsupported type for getRefByUuid: " + type != null ? type.getName() : "null");

Due to Java operator precedence, the ternary operator is evaluated incorrectly, causing the exception message to be wrong and potentially leading to a NullPointerException when type is null.

Proposed Fix
Wrap the ternary expression in parentheses:

throw new APIException( "Unsupported type for getRefByUuid: " + (type != null ? type.getName() : "null") );

Impact

• Generates the correct error message.
• Prevents incorrect evaluation of the ternary expression.
• Avoids a possible NullPointerException when type is null.

JIra Ticker : https://openmrs.atlassian.net/browse/TRUNK-6714

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Kapil-kundu]

@jwnasambu please review the changes

[jwnasambu]

This is a good catch, @Kapil-kundu, and it LGTM. Kindly add test coverage for the null type case in the affected getRefByUuid methods to prevent future regressions.

[jwnasambu]

Kindly also follow this link: https://openmrs.atlassian.net/wiki/spaces/docs/pages/25477199/Pull+Request+Tips to get tips on how to create a good pull request.

[Kapil-kundu]

@jwnasambu can I write test cases only for my changes or should I have to write all the test cases for the files

[jwnasambu]

@Kapil-kundu Kindly write test cases only for the changes you made.

[Kapil-kundu]

@jwnasambu test cases added for what I changed