Enable service monitor for 5G NFs#152
Merged
Merged
Conversation
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds optional Prometheus Operator ServiceMonitor support to the 5g-control-plane Helm chart by exposing a consistent prometheus-exporter Service port on additional 5G NFs and providing chart values to enable ServiceMonitor generation.
Changes:
- Bump chart versions (
sd-coreto 4.1.2,5g-control-planeto 4.1.1) and update dependency pin. - Add a
servicemonitortemplate gated byservicemonitor.enabled. - Expose
prometheus-exporterports for more NF Services and add corresponding values defaults.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| sdcore-helm-charts/Chart.yaml | Bumps umbrella chart version and updates 5g-control-plane dependency version. |
| 5g-control-plane/Chart.yaml | Bumps 5g-control-plane chart version. |
| 5g-control-plane/values.yaml | Adds per-NF prometheus port defaults and a new servicemonitor values section. |
| 5g-control-plane/templates/servicemonitor.yaml | Introduces optional ServiceMonitor resources for selected NFs. |
| 5g-control-plane/templates/service-webui.yaml | Adds prometheus-exporter Service port for WebUI. |
| 5g-control-plane/templates/service-udm.yaml | Adds prometheus-exporter Service port for UDM. |
| 5g-control-plane/templates/service-udr.yaml | Adds prometheus-exporter Service port for UDR. |
| 5g-control-plane/templates/service-pcf.yaml | Adds prometheus-exporter Service port for PCF. |
| 5g-control-plane/templates/service-nssf.yaml | Adds prometheus-exporter Service port for NSSF. |
| 5g-control-plane/templates/service-nrf.yaml | Adds prometheus-exporter Service port for NRF. |
| 5g-control-plane/templates/service-ausf.yaml | Adds prometheus-exporter Service port for AUSF. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
thakurajayL
previously approved these changes
Jul 1, 2026
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
cmaciocco
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.