Wait webui on Mongo and simapp on webui readiness#150
Closed
gab-arrobo wants to merge 9 commits into
Closed
Conversation
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Helm charts to enforce a more correct startup ordering between components: WebUI waits for MongoDB to be reachable, and simapp waits for WebUI to be reachable, with corresponding chart version bumps to release the behavior.
Changes:
- Update
5g-control-planeWebUI initContainer to wait on MongoDB DNS + TCP readiness (instead of waiting onwebuiitself). - Update
omec-sub-provisionsimapp initContainer to wait on WebUI DNS + TCP readiness. - Bump chart versions (
sd-core,5g-control-plane,omec-sub-provision) to publish the change.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
sdcore-helm-charts/Chart.yaml |
Bumps umbrella chart + dependency versions to pull in readiness-order changes. |
omec-sub-provision/templates/deployment-simapp.yaml |
Makes simapp wait for WebUI readiness before starting. |
omec-sub-provision/Chart.yaml |
Version bump for omec-sub-provision release. |
5g-control-plane/templates/deployment-webui.yaml |
Makes WebUI wait for MongoDB readiness before starting. |
5g-control-plane/Chart.yaml |
Version bump for 5g-control-plane release. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
Comment on lines
+8
to
+10
| {{- $mongoUrl := (.Values.config.mongodb.url | default "mongodb://mongodb-headless:27017") }} | ||
| {{- $mongoNoScheme := trimPrefix "mongodb+srv://" (trimPrefix "mongodb://" $mongoUrl) }} | ||
| {{- $mongoAuthorityRaw := first (splitList "/" $mongoNoScheme) }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.