Unify 5GC certs under a shared CA and mount it across control-plane pods#135
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the SD-Core Helm charts to generate all 5GC control-plane TLS leaf certificates from a single shared CA and mounts the shared CA certificate into the relevant control-plane pods.
Changes:
- Introduces a shared CA (public + private Secret) and consolidates per-NF TLS Secret generation into a single
secret-certs.yamltemplate. - Updates 5GC control-plane Deployments to mount both leaf cert/key and shared CA cert via a projected volume, and sets
SSL_CERT_FILEto the mounted CA path. - Bumps chart versions to release the change (
sd-core3.5.1,5g-control-plane3.2.4).
Reviewed changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| sdcore-helm-charts/Chart.yaml | Bumps sd-core chart + 5g-control-plane dependency versions to publish the change. |
| 5g-control-plane/Chart.yaml | Bumps 5g-control-plane chart version. |
| 5g-control-plane/templates/secret-certs.yaml | Adds shared CA + consolidated per-NF TLS Secret generation (and removes per-NF secret templates). |
| 5g-control-plane/templates/_helpers.tpl | Adds shared CA naming helpers; updates gen-certs to accept a provided CA and broaden SANs. |
| 5g-control-plane/templates/deployment-webui.yaml | Mounts leaf certs + shared CA via projected volume; sets SSL_CERT_FILE. |
| 5g-control-plane/templates/deployment-udr.yaml | Mounts leaf certs + shared CA via projected volume; sets SSL_CERT_FILE. |
| 5g-control-plane/templates/deployment-udm.yaml | Mounts leaf certs + shared CA via projected volume; sets SSL_CERT_FILE. |
| 5g-control-plane/templates/deployment-smf.yaml | Mounts leaf certs + shared CA via projected volume; sets SSL_CERT_FILE. |
| 5g-control-plane/templates/deployment-pcf.yaml | Mounts leaf certs + shared CA via projected volume; sets SSL_CERT_FILE. |
| 5g-control-plane/templates/deployment-nssf.yaml | Mounts leaf certs + shared CA via projected volume; sets SSL_CERT_FILE. |
| 5g-control-plane/templates/deployment-nrf.yaml | Mounts leaf certs + shared CA via projected volume; sets SSL_CERT_FILE. |
| 5g-control-plane/templates/deployment-ausf.yaml | Mounts leaf certs + shared CA via projected volume; sets SSL_CERT_FILE. |
| 5g-control-plane/templates/deployment-amf.yaml | Mounts leaf certs + shared CA via projected volume; sets SSL_CERT_FILE. |
| 5g-control-plane/templates/secret-webui.yaml | Removed (replaced by consolidated secret-certs.yaml). |
| 5g-control-plane/templates/secret-udr.yaml | Removed (replaced by consolidated secret-certs.yaml). |
| 5g-control-plane/templates/secret-udm.yaml | Removed (replaced by consolidated secret-certs.yaml). |
| 5g-control-plane/templates/secret-smf.yaml | Removed (replaced by consolidated secret-certs.yaml). |
| 5g-control-plane/templates/secret-pcf.yaml | Removed (replaced by consolidated secret-certs.yaml). |
| 5g-control-plane/templates/secret-nssf.yaml | Removed (replaced by consolidated secret-certs.yaml). |
| 5g-control-plane/templates/secret-nrf.yaml | Removed (replaced by consolidated secret-certs.yaml). |
| 5g-control-plane/templates/secret-ausf.yaml | Removed (replaced by consolidated secret-certs.yaml). |
| 5g-control-plane/templates/secret-amf.yaml | Removed (replaced by consolidated secret-certs.yaml). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 22 out of 22 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 22 out of 22 changed files in this pull request and generated 10 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 22 out of 22 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 22 out of 22 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 22 out of 22 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 22 out of 22 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 22 out of 22 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 24 out of 24 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 24 out of 24 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 24 out of 24 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 24 out of 24 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 24 out of 24 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 24 out of 24 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 24 out of 24 changed files in this pull request and generated 18 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 24 out of 24 changed files in this pull request and generated 10 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 24 out of 24 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
No description provided.