Refactor: Reorganize project structure#2
Merged
Conversation
- Fixed test_client_initialization to not check non-existent environment attribute - Fixed test_dashboard_route_success to mock analyze_transactions - Added 5 new Plaid integration tests for accounts, transactions, and edge cases - Excluded src/main.py from coverage (CLI script not used in Flask app) - All 33 tests passing - Flask app coverage: 87.01% - Overall coverage: 53.33% (excluding main.py)
- Removed old debug script that was causing pytest collection to fail - Script had exit(1) at module level which triggered SystemExit during import - All 33 tests now pass successfully in CI
- Removed test_experian_auth.py (debug script with env var access at module level) - Removed test_experian_gateway.py (debug script with API calls at import) - Only proper unit tests remain: test_app.py, test_experian_integration.py, test_plaid_integration.py - All 33 tests passing locally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
New Structure
\\plaintext
credit-history-app/
src/ # Source code
integrations/ # API clients
templates/ # Flask templates
app.py
main.py
scripts/ # Utility scripts
tests/ # Test files
docs/ # Documentation
.github/ # GitHub configs
Root configs (requirements.txt, render.yaml, etc)
\\
What Changed
Testing
Benefits
Ready to merge!