Clarify MSBuild NuGet onboarding#48
Merged
Merged
Conversation
7a8d178 to
d62cc47
Compare
eea4718 to
4be0a2f
Compare
4be0a2f to
5593631
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PackageReferenceandInstall-Package crtsys, including Build Tools-onlymsbuild /restoreusage.test/nugetconsumer smoke projects.file(DOWNLOAD)status, and fails clearly ifCPMAddPackageis not defined.Impact
This makes it clear that crtsys NuGet consumption works for Visual Studio and Build Tools-only WDK driver projects. It also separates MSBuild/NuGet onboarding from the CMake/CPM/prebuilt paths so readers do not mistake multiple supported paths for extra setup burden.
The package README now carries the package-page quick start directly instead of relying on repository-relative documentation links.
The CPM bootstrap change addresses the app configure failure where the wrapper printed a CPM download message but proceeded to
CPMAddPackagewithout proving that the downloaded CPM script was valid. It now self-heals an invalid cached CPM file by deleting and downloading it again before including it.The x86 change aligns crtsys with the existing script/toolchain capability: x86 driver builds now run in CI and x86 prebuilt driver libraries are packaged alongside x64 and ARM64. Runtime x86 driver load tests still require a 32-bit Windows test machine and remain separate from GitHub-hosted compile/package validation.
Validation
git diff --checktest/nuget/crtsys_nuget_test.vcxproj,nuget/build/native/crtsys.targets, andnuget/build/native/crtsys.propskmlibrary folders exist for x86, x64, and ARM64 under10.0.22621.0nuget/README.mdhas no Markdown documentation links or repository-relative links.Local
cmakeis not available in this shell, so the GitHub Actions jobs should be used to verify the CPM bootstrap and x86 driver/package build expansion.