This repository was archived by the owner on Apr 6, 2020. It is now read-only.
Add support in the Picker to download iCloud image before returning#212
Open
sumeet-gupta wants to merge 2 commits into
Open
Add support in the Picker to download iCloud image before returning#212sumeet-gupta wants to merge 2 commits into
sumeet-gupta wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds support in QBImagePickerController to download photos which are not locally present on the device(i.e. are on iCloud). This by default will not happen, if the user of QBImagePickerController wants this functionality he has to set the downloadiCloudPhotos property of QBImagePickerController. On doing this the picker upon selection will download the image while showing an activity indicator while it download the image and once the image is ready it will make the delegate callback
Why
This helps if the picker is used in multiple places across the app, if this functionality isn't available in the picker the code to download iCloud images has to be written in all the places the picker is used.