Skip to content
This repository was archived by the owner on Apr 6, 2020. It is now read-only.

Crash with deleted photos in iTunes library#180

Open
chrisga wants to merge 1 commit into
nek023:masterfrom
chrisga:fixes
Open

Crash with deleted photos in iTunes library#180
chrisga wants to merge 1 commit into
nek023:masterfrom
chrisga:fixes

Conversation

@chrisga

@chrisga chrisga commented Oct 1, 2016

Copy link
Copy Markdown

When syncing down deleted images from an iPhoto library, it crashes
because the path doesn’t exist anymore.

this commit fixes #171

When syncing down deleted images from an iPhoto library, it crashes
because the path doesn’t exist anymore.
@sroddy

sroddy commented Dec 6, 2016

Copy link
Copy Markdown

Hey,
thanks for the PR! You forgot a closing }.

@chrisga

chrisga commented Apr 22, 2017

Copy link
Copy Markdown
Author

Closing

@chrisga chrisga closed this Apr 22, 2017
@chrisga chrisga reopened this Apr 22, 2017
@shoby

shoby commented Apr 24, 2017

Copy link
Copy Markdown

This pull request reduced crashes.
Thank you @chrisga

However, this pull request cause a build error.

You forgot a closing }. means, if statement in the code is not closed.
https://github.com/questbeat/QBImagePicker/pull/180/files#diff-c79974685eb2efb0f6afb0c39070f79dL411

It needs }.

Could you fix it?

DickSmith pushed a commit to DickSmith/QBImagePicker that referenced this pull request Jan 14, 2019
1. fix from PR nek023#180, but with missing `}`. `: `Fatal Exception: NSInternalInconsistencyException attempt to delete and reload the same index path`
2. fix for `Fatal Exception: NSInvalidArgumentException *** -[NSPlaceholderString initWithString:]: nil argument`
3. fix for `Fatal Exception: NSInternalInconsistencyException negative sizes are not supported in the flow layout`
4. added type safety by explicitly setting some double literals to floats for `Parameter type mismatch: Values of type 'double' may not fit into the receiver type 'CGFloat'`
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash in PhotoLibraryDidChange

3 participants