perf!: replace glob package with node:fs glob#6098
Open
mostafaNazari702 wants to merge 3 commits into
Open
Conversation
mostafaNazari702
force-pushed
the
replace-glob-with-fs-glob
branch
from
June 19, 2026 18:10
598f08a to
8cbec9c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6098 +/- ##
==========================================
- Coverage 82.64% 82.62% -0.03%
==========================================
Files 62 62
Lines 4668 4661 -7
Branches 1003 1032 +29
==========================================
- Hits 3858 3851 -7
Misses 810 810 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
JoshuaKGoldberg
previously approved these changes
Jun 20, 2026
JoshuaKGoldberg
left a comment
Member
There was a problem hiding this comment.
LGTM, nice switch. I tinkered with this a bunch locally. It's a pity we'll have to wait so long to get it in 😢.
Member
|
Blocked on starting v13 |
Co-authored-by: Josh Goldberg ✨ <github@joshuakgoldberg.com>
mostafaNazari702
force-pushed
the
replace-glob-with-fs-glob
branch
from
July 19, 2026 18:20
7e48b4b to
7397618
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
globpackage with built-innode:fs.glob#5962status: accepting prsOverview
Replace the "glob" dependency with Node's built-in node:fs glob plus "minimatch" (which Mocha already depends on, and which glob is itself built on). Removed glob from production dependencies, shrinking what users install.
IMPROTANT
This is a breaking change (semver-major): fs.globSync is only available on Node 22+ and so this drops support for Node.js 20.
enginesis now >=22.12.0, and the CI matrix and docs are updated to match.