Skip to content

fix: serialize parallel test results without mutating user objects#6057

Draft
GrahamCampbell wants to merge 1 commit into
mochajs:v11.xfrom
GrahamCampbell:fix/parallel-serializer-mutation-11x
Draft

fix: serialize parallel test results without mutating user objects#6057
GrahamCampbell wants to merge 1 commit into
mochajs:v11.xfrom
GrahamCampbell:fix/parallel-serializer-mutation-11x

Conversation

@GrahamCampbell

Copy link
Copy Markdown
Contributor

PR Checklist

Overview

Backport of #6056 to v11.x, the current stable line. The serializer here (lib/nodejs/serializer.js) is identical to main's serializer.mjs apart from the CJS/ESM module wrappers, so the change transposes one-to-one — see #6056 for the full description of the bug and the fix.

On this branch the full node-unit suite passes (598 tests, including the 20 new serializer regression tests), as do the parallel integration specs (circular-reference and getter fixtures) and an end-to-end run of the #6053 repro: the original failure is reported, and require('crypto') keeps its functions in the reused worker.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Hi @GrahamCampbell, thanks for the pull request! A scan flagged a concern with it. Could you please take a look?

[pr-task-completion] This PR's body is missing [x] checks on the following tasks from the PR template.

Repositories often provide a set of tasks that pull request authors are expected to complete. Those tasks should be marked as completed with a [x] in the pull request description. Please complete those tasks and mark the checks as [x] completed.

🗺️ This message was posted automatically by OctoGuide: a bot for GitHub repository best practices.

@mark-wiemer

Copy link
Copy Markdown
Member

Marking as draft until backing issue is out of triage

@mark-wiemer
mark-wiemer marked this pull request as draft June 11, 2026 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants