fix: serialize parallel test results without mutating user objects#6057
Draft
GrahamCampbell wants to merge 1 commit into
Draft
fix: serialize parallel test results without mutating user objects#6057GrahamCampbell wants to merge 1 commit into
GrahamCampbell wants to merge 1 commit into
Conversation
Contributor
|
👋 Hi @GrahamCampbell, thanks for the pull request! A scan flagged a concern with it. Could you please take a look? [pr-task-completion] This PR's body is missing
Repositories often provide a set of tasks that pull request authors are expected to complete. Those tasks should be marked as completed with a
|
Member
|
Marking as draft until backing issue is out of triage |
mark-wiemer
marked this pull request as draft
June 11, 2026 01:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
Backport of #6056 to v11.x, the current stable line. The serializer here (
lib/nodejs/serializer.js) is identical tomain'sserializer.mjsapart from the CJS/ESM module wrappers, so the change transposes one-to-one — see #6056 for the full description of the bug and the fix.On this branch the full node-unit suite passes (598 tests, including the 20 new serializer regression tests), as do the parallel integration specs (circular-reference and getter fixtures) and an end-to-end run of the #6053 repro: the original failure is reported, and
require('crypto')keeps its functions in the reused worker.