Fix IL2CPP OpenXR hook trampoline#10
Draft
andybak wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an Android IL2CPP launch failure in Unity OpenXR Extensions.
On Quest, Open Brush was hanging during launch because OpenXR initialization threw NotSupportedException when IL2CPP
tried to marshal FeatureBase.Intercepted_xrGetInstanceProcAddr. Although the method had MonoPInvokeCallback, it
lived inside a generic class, so the closed generic feature types still failed at runtime.
This moves the xrGetInstanceProcAddr trampoline into a non-generic helper with a single MonoPInvokeCallback entry
point, while keeping per-feature handlers registered from FeatureBase. That lets multiple OpenXR extension features
hook function lookup without requiring IL2CPP to marshal a generic-class callback.