Do not scroll on paste images#3400
Merged
Merged
Conversation
|
juliaroldi
requested review from
BryanValverdeU,
JiuqingSong,
flyingbee2012,
ianeli1 and
vinguyen12
and removed request for
JiuqingSong
July 20, 2026 20:12
JiuqingSong
reviewed
Jul 20, 2026
| return {}; | ||
| } | ||
|
|
||
| function isImageFragment(pasteFragment: DocumentFragment): boolean { |
Collaborator
There was a problem hiding this comment.
So this check if the only pasted content is image?
Then you can name it isImageOnlyFragment
And to simplify the check, you can first querySelectorAll('img') and check there is exactly one result, and check element.textContent.trim() == ''
Collaborator
There was a problem hiding this comment.
btw, what if the pasted content is a table and its only content is an image? do you want to scroll in that case?
Contributor
Author
There was a problem hiding this comment.
I don't think we should allow scrolling when a table contains only an image, and the same goes for an anchor element that contains only an image.
JiuqingSong
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pasting large images can cause the editor to jump far into view, which forces the user to scroll back to where the cursor was. When images are pasted, the caret should not be scrolled into view.