[AutoFormat] Handle input exclusively#3162
Merged
Merged
Conversation
juliaroldi
requested review from
BryanValverdeU,
JiuqingSong,
flyingbee2012,
ianeli1 and
vinguyen12
and removed request for
BryanValverdeU
September 26, 2025 20:42
JiuqingSong
reviewed
Sep 26, 2025
| return false; | ||
| } | ||
|
|
||
| return isLastWordUrl(previousText) || isLetterFollowedByMarker(previousText); |
Collaborator
There was a problem hiding this comment.
Ideally, we should have a same check when checking exclusiveness and really handle the event, rather than having separate functions.
But if that is too hard to refactor, or have bad perf impact, then it is ok to keep them separate.
Can you double check?
Contributor
Author
There was a problem hiding this comment.
I changed the code to use the getListTypeStyle and promoteLink, if these functions do have return, we should handle the event exclusively.
JiuqingSong
approved these changes
Oct 1, 2025
BryanValverdeU
approved these changes
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After inputting a link URL or characters that triggers a list, handle the input event exclusively to avoid auto capitalization, when AutoCorrect Plugin is enabled.