[Integrations] Fix missing SVG logos for Rustrial AWS EKS IAM Auth Controller#2724
[Integrations] Fix missing SVG logos for Rustrial AWS EKS IAM Auth Controller#2724ChaitanyaSai-Meka wants to merge 4 commits into
Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
✅ Deploy Preview for mesheryio-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds several SVG icon files for the rustrial-aws-eks-iam-auth-controller integration. The reviewer identified that the id attributes in all four SVG files contain forward slashes, which violate the W3C XML specification for ID attributes and could cause parsing or querying issues. It is recommended to remove these unused ID attributes to clean up and optimize the SVG code.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
ChaitanyaSai-Meka
force-pushed
the
fix-rustrial-aws-logo
branch
from
fc86b20 to
9a6c271
Compare
…-auth-controller Signed-off-by: ChaitanyaSai-Meka <chaitanya.s.meka@gmail.com>
…m-auth-controller Signed-off-by: ChaitanyaSai-Meka <chaitanya.s.meka@gmail.com>
ChaitanyaSai-Meka
force-pushed
the
fix-rustrial-aws-logo
branch
from
31d237b to
7000650
Compare
rishiraj38
left a comment
rishiraj38
left a comment
There was a problem hiding this comment.
@ChaitanyaSai-Meka, please verify the SVGs added against the Meshery Integration Spreadsheet, as we source integration icons from there.
|
Hey @rishiraj38 , I checked the spreadsheet, but the SVG columns for this integration are currently blank. Let me know if the ones I provided in the PR are good to go, or if I should pull them from somewhere else! |
|
@ChaitanyaSai-Meka Thank you for your contribution! Let's discuss this during the website call tomorrow at 5:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂 |
|
@Bhumikagarggg, I have added this as an agenda item to the meeting minutes. |
Okay! See you in tomorrow’s website call 👋 |
Description
This PR fixes #2723
What changed:
rustrial-aws-eks-iam-auth-controllerintegration with valid AWS IAM SVG content.colorandwhiteimage paths within theintegrations/data.jsJSON entry so the UI can correctly map and render the assets.Notes for Reviewers
.svgfiles inassets/images/integration/rustrial-aws-eks-iam-auth-controller/with valid XML/SVG paths.Signed commits