Add support for results generated with PointsReporter#50
Open
MikolajKolek wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when receiving results generated with the Satori PointsReporter that don't start with 100, but are still correct (for example
25 [25 / 25]), the problems page displays the problem as not correctly solved, even if it is. This PR fixes that by introducing a new regex check.Additionally, I think that the
status.startsWith('100')line might work under the incorrect assumption that all problems are scored out of 100, and I don't understand what the andACCURACY_REGEXexpression checks for as I don't see reporters in the Satori source code that would ever give matching results, but my understanding of Satori code is mediocre at best, so maybe they are there for a good reason and I'm in the wrong here.