test(agentic): add EvalScope trie benchmark protocol#466
Draft
Xiangyi1996 wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Xiangyi Zhang <xiangyiz@nvidia.com> Co-authored-by: Jiying Dong <87510204+dongjiyingdjy@users.noreply.github.com>
337b01e to
a40035f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This draft adds a reusable EvalScope trie benchmark protocol/tooling path for agentic serving comparisons.
The protocol is based on Jiying Dong's EvalScope trie workflow and the follow-up discussion around warmup, formal sweep sizing, prompt serialization, and metric alignment. The goal is to make TRTLLM and TokenSpeed runs use the same workload, request parameters, warmup protocol, prompt serialization, and metric definitions before we compare V4-Pro agentic serving results.
What changed
test/agentic_benchmark/evalscope_trie/run_evalscope_trie_sweep.sh:collect_outputs.py:Completion TPS/userOutput Token/Min/GPUScope
This PR does not launch or configure the server. TokenSpeed, TRTLLM, or another backend should be started separately, and backend-specific launch flags should be recorded next to each benchmark run.
Test Plan
pre-commit run --all-filespython -m pytest test/agentic_benchmark/test_evalscope_trie_collect_outputs.py -qNotes
Opening as draft first so Jiying can review whether the protocol attribution and default settings match the workflow she proposed before this is marked ready for review.