feat(fan): add ceiling-fan control for light+fan combos like H1310 (#74)#90
Merged
Conversation
…ixes #74) The H1310 reports as devices.types.light, so it only got a light entity — its integrated fan (fanToggle / fanSpeedMode / reverseAirflowToggle) had no control. Add GoveeCeilingFanEntity for devices exposing those capabilities, giving on/off, 6-speed control, and reverse-airflow direction. State is optimistic + RestoreEntity since Govee's poll doesn't return fan state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #74. The H1310 reports as
devices.types.lightso it only got a light entity; its integrated fan (fanToggle/fanSpeedMode/reverseAirflowToggle) had no control. AddsGoveeCeilingFanEntity(on/off, 6-speed, reverse-airflow direction), optimistic + RestoreEntity since the poll doesn't return fan state.Tests: 770 passed. mypy (40 files) + flake8 clean.