fix: issue 2043, revising connector cards display and ui for better user understanding.#2105
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughConnector metadata now identifies OAuth connectors, backend status responses report environment credentials, and the settings UI displays configured OAuth connectors separately from credential-based connectors. Azure Blob availability defaults off, and the Azurite data volume is declared. ChangesConnector configuration flow
Azure Blob availability
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant ConnectorSettings
participant ConnectorQuery
participant ConnectionManager
participant ConnectorStatusAPI
participant OAuthConnector
ConnectorSettings->>ConnectorQuery: request connector metadata and status
ConnectorQuery->>ConnectionManager: read connector kind metadata
ConnectionManager-->>ConnectorQuery: return connector kind
ConnectorQuery->>ConnectorStatusAPI: request connector status
ConnectorStatusAPI->>OAuthConnector: check client ID and client secret
OAuthConnector-->>ConnectorStatusAPI: return credential availability
ConnectorStatusAPI-->>ConnectorQuery: return has_env_credentials
ConnectorQuery-->>ConnectorSettings: render OAuth and credential sections
Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@frontend/app/settings/_components/connector-card.tsx`:
- Around line 107-111: Update the connector status message conditional in the
connector card so connector?.available alone does not produce “is configured.”
Preserve that message for isConfigured connectors, while credential-based
connectors that are only enabled and not connected should use messaging
indicating they are available to connect or still require credentials.
In `@src/api/connectors.py`:
- Around line 1409-1430: Move the OAuth environment-credential detection from
the route handler into the connector_service layer, exposing a method such as
has_env_credentials(connector_type) that performs connector lookup,
instantiation, and credential checks while preserving the existing boolean and
exception behavior. Update the route handler’s has_env_credentials assignment to
call that service method, leaving the response construction unchanged.
In `@src/config/settings.py`:
- Around line 280-289: Update is_azure_blob_enabled so OSS mode requires both
OPENRAG_AZURE_BLOB_ENABLED and OPENRAG_DEV_AZURE_BLOB to be enabled, while
IBM_AUTH_ENABLED mode requires only OPENRAG_AZURE_BLOB_ENABLED. Preserve the
documented force-hide behavior when the main flag is disabled.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: a10ba6ad-c1e3-45f4-a22e-8f708c0e0759
📒 Files selected for processing (7)
docker-compose.ymlfrontend/app/api/queries/useGetConnectorsQuery.tsfrontend/app/settings/_components/connector-card.tsxfrontend/app/settings/_components/connector-cards.tsxsrc/api/connectors.pysrc/config/settings.pysrc/connectors/connection_manager.py
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
…hub.com/langflow-ai/openrag into split-connector-behavior-based-on-oauth
…hub.com/langflow-ai/openrag into split-connector-behavior-based-on-oauth
Fixes issue #2043
Problem
After disconnecting a connector (Azure Blob Storage, AWS S3, etc.), the card still displayed "{Connector name} is configured." instead of showing the expected "credentials not configured yet" message.
Root Cause
The condition in
connector-card.tsxwas checkingisConnected || connector?.available, whereavailableindicates whether the connector is allowed for the workspace. This field remainstrueafter disconnection, causing the incorrect message to persist.Solution
Hide unavailable connectors and improve connector status detection
Fixes connector visibility and status detection issues.
Changes
available: falsein frontendrequiresOAuthfield to distinguish OAuth vs credential-based connectorsBackend
has_env_credentialscheck in connector status endpoint for OAuth connectorsget_available_connector_typesto returnrequiresOAuthfieldFrontend
Summary by CodeRabbit