Fix duplicate dialog

frontend/app/upload/[provider]/page.tsx

@@ -2,7 +2,7 @@
 
 import { AlertCircle, ArrowLeft } from "lucide-react";
 import { useParams, useRouter } from "next/navigation";
-import { useRef, useState } from "react";
+import { useState } from "react";
 import { toast } from "sonner";
 import { useSyncConnector } from "@/app/api/mutations/useSyncConnector";
 import { useGetConnectorsQuery } from "@/app/api/queries/useGetConnectorsQuery";
@@ -17,16 +17,12 @@ import {
   TooltipTrigger,
 } from "@/components/ui/tooltip";
 import { useTask } from "@/contexts/task-context";
+import { useDuplicateDialogFlow } from "@/hooks/useDuplicateDialogFlow";
 import { useSessionIngestSettings } from "@/hooks/useSessionIngestSettings";
 import { trackProcessFailure, trackStartProcess } from "@/lib/analytics";
+import { checkConnectorDuplicates } from "@/lib/connectors/check-duplicates";
 import { getConnectorDescriptor } from "@/lib/connectors/registry";
 
-interface ConnectorDuplicateCheckResponse {
-  duplicate_names?: string[];
-  duplicate_count?: number;
-  non_duplicate_files?: CloudFile[];
-}
-
 // CloudFile interface is now imported from the unified cloud picker
 
 export default function UploadProviderPage() {
@@ -68,15 +64,6 @@ export default function UploadProviderPage() {
   const [selectedFiles, setSelectedFiles] = useState<CloudFile[]>([]);
   const [ingestSettings, setIngestSettings] = useSessionIngestSettings();
   const [isCheckingDuplicates, setIsCheckingDuplicates] = useState(false);
-  const [duplicateDialogOpen, setDuplicateDialogOpen] = useState(false);
-  const [pendingSync, setPendingSync] = useState<{
-    connector: { connectionId?: string; type: string };
-    allFiles: CloudFile[];
-    nonDuplicateFiles: CloudFile[];
-    duplicateNames: string[];
-    duplicateCount: number;
-  } | null>(null);
-  const isOverwriteConfirmedRef = useRef(false);
 
   const accessToken = tokenData?.access_token || null;
   const isLoading =
@@ -152,6 +139,26 @@ export default function UploadProviderPage() {
 
   const getProviderDisplayName = () => descriptor?.name ?? provider;
 
+  const {
+    dialogOpen: duplicateDialogOpen,
+    duplicateNames,
+    duplicateCount,
+    openDialog: openDuplicateDialog,
+    handleOverwrite: handleOverwriteDuplicates,
+    handleSkip: handleSkipDuplicates,
+    handleOpenChange: handleDuplicateDialogOpenChange,
+  } = useDuplicateDialogFlow<
+    CloudFile,
+    { connectionId?: string; type: string }
+  >({
+    onSubmit: (files, replaceDuplicates, pending) => {
+      if (!pending.meta) return;
+      submitSync(pending.meta, files, replaceDuplicates);
+    },
+    allSkippedMessage: (pending) =>
+      `All ${pending.duplicateCount} selected file(s) already exist. Nothing was synced.`,
+  });
+
   const handleSync = async (connector: {
     connectionId?: string;
     type: string;
@@ -166,54 +173,30 @@ export default function UploadProviderPage() {
 
     setIsCheckingDuplicates(true);
     try {
-      const checkResponse = await fetch(
-        `/api/connectors/${connector.type}/check-duplicates`,
-        {
-          method: "POST",
-          headers: {
-            "Content-Type": "application/json",
-          },
-          body: JSON.stringify({
-            connection_id: connector.connectionId,
-            selected_files: selectedFiles.map((file) => ({
-              id: file.id,
-              name: file.name,
-              mimeType: file.mimeType,
-              downloadUrl: file.downloadUrl,
-              size: file.size,
-              isFolder: file.isFolder,
-            })),
-          }),
-        },
-      );
-
-      if (!checkResponse.ok) {
-        throw new Error(`Duplicate check failed: ${checkResponse.statusText}`);
-      }
-
-      const checkData =
-        (await checkResponse.json()) as ConnectorDuplicateCheckResponse;
-      const duplicateNames = checkData.duplicate_names || [];
-      const duplicateCount =
-        typeof checkData.duplicate_count === "number"
-          ? checkData.duplicate_count
-          : duplicateNames.length;
+      const result = await checkConnectorDuplicates<CloudFile>(connector.type, {
+        connection_id: connector.connectionId,
+        selected_files: selectedFiles.map((file) => ({
+          id: file.id,
+          name: file.name,
+          mimeType: file.mimeType,
+          downloadUrl: file.downloadUrl,
+          size: file.size,
+          isFolder: file.isFolder,
+        })),
+      });
 
-      if (duplicateCount === 0) {
+      if (result.duplicateCount === 0) {
         submitSync(connector, selectedFiles, false);
         return;
       }
 
-      const nonDuplicateFiles = checkData.non_duplicate_files || [];
-
-      setPendingSync({
-        connector,
+      openDuplicateDialog({
         allFiles: selectedFiles,
-        nonDuplicateFiles,
-        duplicateNames,
-        duplicateCount,
+        nonDuplicateFiles: result.nonDuplicateFiles,
+        duplicateNames: result.duplicateNames,
+        duplicateCount: result.duplicateCount,
+        meta: connector,
       });
-      setDuplicateDialogOpen(true);
     } catch (err) {
       console.error("[Connector Sync] Duplicate check failed:", err);
       // Fallback: proceed without overwrite
@@ -223,36 +206,6 @@ export default function UploadProviderPage() {
     }
   };
 
-  const handleOverwriteDuplicates = () => {
-    if (!pendingSync) return;
-    isOverwriteConfirmedRef.current = true;
-    const { connector, allFiles } = pendingSync;
-    submitSync(connector, allFiles, true);
-    setPendingSync(null);
-  };
-
-  const handleDuplicateDialogOpenChange = (open: boolean) => {
-    if (!open && pendingSync) {
-      if (isOverwriteConfirmedRef.current) {
-        // Overwrite already submitted in handleOverwriteDuplicates; this close
-        // event fires immediately after and would otherwise re-enter the
-        // "skip duplicates" branch.
-        isOverwriteConfirmedRef.current = false;
-      } else {
-        const { connector, nonDuplicateFiles, duplicateCount } = pendingSync;
-        if (nonDuplicateFiles.length > 0) {
-          submitSync(connector, nonDuplicateFiles, false);
-        } else {
-          toast.info(
-            `All ${duplicateCount} selected file(s) already exist. Nothing was synced.`,
-          );
-        }
-      }
-      setPendingSync(null);
-    }
-    setDuplicateDialogOpen(open);
-  };
-
   if (isLoading) {
     return (
       <div className="flex items-center justify-center py-12">
@@ -451,9 +404,10 @@ export default function UploadProviderPage() {
         open={duplicateDialogOpen}
         onOpenChange={handleDuplicateDialogOpenChange}
         onOverwrite={handleOverwriteDuplicates}
+        onSkip={handleSkipDuplicates}
         isLoading={isIngesting}
-        duplicateNames={pendingSync?.duplicateNames}
-        duplicateCount={pendingSync?.duplicateCount}
+        duplicateNames={duplicateNames}
+        duplicateCount={duplicateCount}
       />
     </>
   );