Skip to content

fix: ingesting single files in azure blob now properly navigates to knowledge page#2057

Merged
Vchen7629 merged 5 commits into
mainfrom
azure-blob-redirect-fix
Jul 13, 2026
Merged

fix: ingesting single files in azure blob now properly navigates to knowledge page#2057
Vchen7629 merged 5 commits into
mainfrom
azure-blob-redirect-fix

Conversation

@Vchen7629

@Vchen7629 Vchen7629 commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fixes #2041 , Before Ingesting individually-selected files from a bucket connector would close the file-browser but left the user stuck on the "Add from Azure Blob Storage" pane, because FileBrowserDialog discarded its sync result and never navigated or registered the ingest tasks. This pr adds a new onIngestSuccess callback so SharedBucketView which mirrors the container path (track task_ids + navigate to Knowledge) and fixes all bucket connectors

Before

screen-capture.9.webm

After

screen-capture.10.webm

Changes

  • FileBrowserDialog now accepts an optional onIngestSuccess(result) callback; handleIngest captures the sync mutation result (previously discarded) and invokes it after a successful ingest
  • SharedBucketView wires onIngestSuccess to mirror its whole-container path — invalidate the container-status query, register the returned task_ids, and call onDone() to navigate to Knowledge
  • Added a trackIngestTasks helper in shared-bucket-view.tsx to share the task_idsaddTask loop between the container and individual-file ingest paths

Summary by CodeRabbit

  • New Features

    • Improved background task tracking after file ingestion for a more consistent, up-to-date UI.
    • The file browser dialog now supports an optional callback that runs after ingestion completes.
  • Bug Fixes

    • Fixed inconsistencies in how newly created ingest tasks were tracked and how related refresh behavior triggered across both shared bucket and file browser ingestion flows.

…onnectors

Signed-off-by: vchen7629 <chenvincent7629@gmail.com>
@github-actions github-actions Bot added frontend 🟨 Issues related to the UI/UX bug 🔴 Something isn't working. labels Jul 8, 2026
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

React Doctor found no new issues. 🎉

Reviewed by React Doctor for commit ef3b53b.

@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 69b470ad-8fe2-4974-b308-3579c014f4c5

📥 Commits

Reviewing files that changed from the base of the PR and between 7e0359f and 3753ed2.

📒 Files selected for processing (2)
  • frontend/components/connectors/shared-bucket-view.tsx
  • frontend/components/file-browser-dialog.tsx
🚧 Files skipped from review as they are similar to previous changes (2)
  • frontend/components/connectors/shared-bucket-view.tsx
  • frontend/components/file-browser-dialog.tsx

Walkthrough

SharedBucketView centralizes ingest task tracking in a helper and uses it for both its own ingest mutation and a new FileBrowserDialog success callback. FileBrowserDialog now exposes an optional ingest-success hook and passes the mutation result to it before closing.

Changes

Ingest task tracking and dialog callback

Layer / File(s) Summary
trackIngestTasks helper and main ingest flow
frontend/components/connectors/shared-bucket-view.tsx
Adds a trackIngestTasks helper that forwards each task id to addTask with connector metadata, and replaces the inline loop in the main ingest success path.
FileBrowserDialog onIngestSuccess prop and invocation
frontend/components/file-browser-dialog.tsx
Adds optional onIngestSuccess to the dialog props, captures the ingest result from mutateAsync, invokes the callback with it, and updates the hook dependencies.
FileBrowserDialog onIngestSuccess handler wiring in SharedBucketView
frontend/components/connectors/shared-bucket-view.tsx
Passes an onIngestSuccess handler that invalidates the query, tracks task ids, and calls onDone, or shows an info toast when no tasks are queued.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • langflow-ai/openrag#1887: Both PRs touch ingest task creation in shared-bucket-view and preserve connector-type metadata in addTask.
  • langflow-ai/openrag#1933: Both PRs update ingest success handling in shared-bucket-view.tsx and use source: "connector" in task tracking.

Suggested reviewers: mfortman11, Wallgau

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main fix: Azure Blob file ingest now navigates to the Knowledge page.
Linked Issues check ✅ Passed The changes add a success callback and reuse it to trigger Knowledge navigation after individual-file ingest, matching #2041.
Out of Scope Changes check ✅ Passed The edits stay focused on ingest success handling and task tracking for the Azure Blob file browser flow.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch azure-blob-redirect-fix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added bug 🔴 Something isn't working. and removed bug 🔴 Something isn't working. labels Jul 8, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@frontend/components/connectors/shared-bucket-view.tsx`:
- Around line 346-350: The individual-file onIngestSuccess handler in
shared-bucket-view should match the container ingest flow by guarding on
result.task_ids before calling onDone(). Update the onIngestSuccess callback to
only invalidate, trackIngestTasks, and navigate when result.task_ids?.length is
truthy; otherwise show the same toast/info fallback used in the container path.
Use the existing onIngestSuccess, trackIngestTasks, onDone, and result.task_ids
references to locate the change.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 46350e97-49cc-4664-98a2-09fc6cac2114

📥 Commits

Reviewing files that changed from the base of the PR and between 8e0f30b and c92f66c.

📒 Files selected for processing (2)
  • frontend/components/connectors/shared-bucket-view.tsx
  • frontend/components/file-browser-dialog.tsx

Comment thread frontend/components/connectors/shared-bucket-view.tsx
@github-actions github-actions Bot added bug 🔴 Something isn't working. and removed bug 🔴 Something isn't working. labels Jul 9, 2026
@github-actions github-actions Bot added bug 🔴 Something isn't working. and removed bug 🔴 Something isn't working. labels Jul 9, 2026
Wallgau
Wallgau previously requested changes Jul 9, 2026

@Wallgau Wallgau left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, left some notes. The main thing I want to make sure of before we merge is that we're not dropping context by hardcoding user-facing messages where the backend already returns something more specific. Otherwise this looks good.

@Vchen7629
Vchen7629 requested a review from Wallgau July 9, 2026 16:06
@github-actions github-actions Bot added bug 🔴 Something isn't working. and removed bug 🔴 Something isn't working. labels Jul 9, 2026
@Vchen7629
Vchen7629 dismissed Wallgau’s stale review July 9, 2026 16:07

Replaced hardcoded toast message with backend message + fallback

@github-actions github-actions Bot added bug 🔴 Something isn't working. and removed bug 🔴 Something isn't working. labels Jul 9, 2026
@github-actions github-actions Bot added bug 🔴 Something isn't working. and removed bug 🔴 Something isn't working. labels Jul 10, 2026

@Wallgau Wallgau left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@github-actions github-actions Bot added the lgtm label Jul 13, 2026
@Vchen7629
Vchen7629 merged commit d37f8fc into main Jul 13, 2026
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug 🔴 Something isn't working. frontend 🟨 Issues related to the UI/UX lgtm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Azure Blog Storage Connector: Ingest action does not automatically trigger a transition to the "Knowledge" page

2 participants