fix: make small pageless documents work on langflowless ingestion#2042
Merged
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and fixes across both the frontend and backend. The main changes include registering the
RowApiModulefor AG Grid in the frontend, enhancing the robustness of document processing utilities, and ensuring configuration values for chunking are properly set in the document processor.Frontend Enhancements:
RowApiModulein both the module imports and theModuleRegistry.registerModulescall to enable additional row-level API features in AG Grid. [1] [2]Backend Improvements:
Document processing utilities:
page_noinextract_relevantby adding a type check for provenance data, preventing errors if the provenance is not a dictionary. [1] [2]Document processor configuration:
process_document_standardto fall back to workspace configuration values forchunk_sizeandchunk_overlapif they are not explicitly provided, ensuring consistent chunking behavior.