Skip to content

fix: make small pageless documents work on langflowless ingestion#2042

Merged
lucaseduoli merged 2 commits into
release-cpd-0.1from
fix/disable_ingestion_page_n
Jul 7, 2026
Merged

fix: make small pageless documents work on langflowless ingestion#2042
lucaseduoli merged 2 commits into
release-cpd-0.1from
fix/disable_ingestion_page_n

Conversation

@lucaseduoli

Copy link
Copy Markdown
Collaborator

This pull request introduces several improvements and fixes across both the frontend and backend. The main changes include registering the RowApiModule for AG Grid in the frontend, enhancing the robustness of document processing utilities, and ensuring configuration values for chunking are properly set in the document processor.

Frontend Enhancements:

  • AG Grid configuration:
    • Registered the RowApiModule in both the module imports and the ModuleRegistry.registerModules call to enable additional row-level API features in AG Grid. [1] [2]

Backend Improvements:

  • Document processing utilities:

    • Improved extraction of page_no in extract_relevant by adding a type check for provenance data, preventing errors if the provenance is not a dictionary. [1] [2]
  • Document processor configuration:

    • Updated process_document_standard to fall back to workspace configuration values for chunk_size and chunk_overlap if they are not explicitly provided, ensuring consistent chunking behavior.

@lucaseduoli
lucaseduoli requested a review from ricofurtado July 7, 2026 20:56
@lucaseduoli lucaseduoli self-assigned this Jul 7, 2026
@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 40c94998-42e3-41fb-9b51-a322cc610ab2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/disable_ingestion_page_n

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added frontend 🟨 Issues related to the UI/UX backend 🔷 Issues related to backend services (OpenSearch, Langflow, APIs) bug 🔴 Something isn't working. labels Jul 7, 2026
@github-actions github-actions Bot added bug 🔴 Something isn't working. and removed bug 🔴 Something isn't working. labels Jul 7, 2026
@lucaseduoli
lucaseduoli requested a review from mfortman11 July 7, 2026 21:38

@mfortman11 mfortman11 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix

@github-actions github-actions Bot added the lgtm label Jul 7, 2026
@lucaseduoli
lucaseduoli merged commit 23351eb into release-cpd-0.1 Jul 7, 2026
12 of 13 checks passed
@github-actions
github-actions Bot deleted the fix/disable_ingestion_page_n branch July 7, 2026 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend 🔷 Issues related to backend services (OpenSearch, Langflow, APIs) bug 🔴 Something isn't working. frontend 🟨 Issues related to the UI/UX lgtm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants