fix: report actual synced connection count in connector_sync (#1547)

[hunterxtang]

Fixes #1547 on main. Clean cherry-pick of #1930 (merged into release-0.5.1); applies without conflicts and the regression test passes unmodified against main's current connector_sync (and fails with assert 3 == 1 without the fix).

Two notes for reviewers: (1) since 0.5.1, main's bucket_filter path can populate task_ids with two batches (new + changed) from the single working connection, so connections_synced: len(task_ids) can read 2 on that path even though one connection was synced — happy to hardcode 1 instead if preferred; (2) per @lucaseduoli's note on #1930 that the test's hardcoded 1 makes it tautological, I'm fine dropping or tightening the test if that's the consensus — kept it for parity with what was approved there.

Summary by CodeRabbit

• Bug Fixes
  • Updated sync responses to report the number of synced tasks more accurately.
  • Improved the success message to use singular wording when only one connection is synced.
  • Added coverage to verify the sync response returns the expected count and message when only one connector connection succeeds.

[coderabbitai]

Walkthrough

The connector_sync endpoint response was modified to report connections_synced based on the number of dispatched task_ids rather than active connections, with a corresponding singular message wording. A new unit test validates this fix using mocked multiple connections with a single successful authentication.

Changes

Connector Sync Response Fix

Layer / File(s)	Summary
Response payload correction src/api/connectors.py	connections_synced now uses len(task_ids) instead of len(active_connections), and the message wording is fixed to state "1 {connector_type} connection".
Regression test tests/unit/api/test_connector_sync_response.py	New async test mocks multiple active connections with only one successful authentication, verifying connections_synced == 1, singular message, one dispatched task_id, and a single sync call for the successful connector.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Poem

A rabbit counted connections with glee,
Too many synced, or so it would seem to be.
Now task_ids tell the real tale,
One connection, no inflated fail.
Tests confirm the count rings true — hop, hop, hooray, review!

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	The change updates connections_synced to use the dispatched task count and adds a regression test for the reported bug.
Out of Scope Changes check	✅ Passed	The only code additions are the response fix and matching regression test, which are directly in scope.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main fix: reporting the actual synced connection count in connector_sync.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/1547-connections-synced-count-main

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

src/api/connectors.py (1)

1194-1200: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Message hardcodes "1" but connections_synced can be 2.

The bucket_filter branch can push two entries onto task_ids (new_ids batch at line 1039 and changed_ids batch at line 1049), so len(task_ids) can be 2 while the message text is hardcoded to f"Started syncing files from 1 {connector_type} connection". This produces an inconsistent, misleading response (e.g. connections_synced: 2 alongside "1 google_drive connection"), and the singular wording is also grammatically wrong when the count isn't 1. This is exactly the discrepancy flagged in the PR description itself as a residual risk from the bucket_filter two-batch behavior.

🐛 Proposed fix to keep message and count consistent

-                "message": f"Started syncing files from 1 {connector_type} connection",
+                "message": (
+                    f"Started syncing files from {len(task_ids)} {connector_type} "
+                    f"connection{'s' if len(task_ids) != 1 else ''}"
+                ),
                 "connections_synced": len(task_ids),

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/api/connectors.py` around lines 1194 - 1200, The response message in the
JSONResponse is hardcoded to “1” even though task_ids can contain more than one
synced connection, which makes it inconsistent with connections_synced. Update
the message construction in the connector sync response to use the actual count
from len(task_ids) and choose singular/plural wording appropriately. Keep the
fix localized to the return JSONResponse block and ensure the text matches the
value reported by task_ids and connections_synced.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@src/api/connectors.py`:
- Around line 1194-1200: The response message in the JSONResponse is hardcoded
to “1” even though task_ids can contain more than one synced connection, which
makes it inconsistent with connections_synced. Update the message construction
in the connector sync response to use the actual count from len(task_ids) and
choose singular/plural wording appropriately. Keep the fix localized to the
return JSONResponse block and ensure the text matches the value reported by
task_ids and connections_synced.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 280c866e-2b1a-4961-a849-00094f348a7e

📥 Commits

Reviewing files that changed from the base of the PR and between 4f104ec and f9b3ccf.

📒 Files selected for processing (2)

• src/api/connectors.py
• tests/unit/api/test_connector_sync_response.py