feat: add react doctor to the ci#1984
Merged
Merged
Conversation
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughThis PR extracts inline async fetch/mutation functions to module scope across numerous React Query hooks, hoists component-local helper functions to module level, fixes minor logic patterns ( ChangesFrontend refactors and UI updates
React Doctor CI workflow
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
enhancement
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/lint-frontend.yml:
- Around line 72-76: The React Doctor checks in the lint-frontend workflow are
using a moving target, which makes the CI result unstable. Update both
invocations in the workflow to use a fixed, validated react-doctor version
instead of `@latest`, keeping the score check and verbose fallback aligned by
referencing the same pinned version in the existing SCORE assignment and the
failure-reporting npx call.
- Line 56: The checkout step in the lint-frontend workflow should disable
persisted Git credentials because this job does not need authenticated git
access and later runs third-party code. Update the actions/checkout usage in the
workflow to set persist-credentials to false so the token is not exposed
unnecessarily.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 957aab8b-4e3d-471d-935c-c3d1fab21905
📒 Files selected for processing (1)
.github/workflows/lint-frontend.yml
github-actions
Bot
added
frontend
github-actions
Bot
added
enhancement
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@frontend/components/navigation.tsx`:
- Around line 522-531: The overflow trigger in navigation.tsx is currently
rendered as a real button inside the conversation row’s outer row button,
creating invalid nested interactive elements. Update the row structure in the
conversation item so the primary row action and the More options trigger are
siblings, or make the trigger non-button while the row remains the button; use
the existing button wrapper and EllipsisVertical trigger placement to locate and
refactor this interaction.
In `@frontend/components/ui/command.tsx`:
- Line 43: The wrapper data attribute in the command input area is out of sync
with the selector used by CommandDialog, so the SVG sizing rule no longer
applies. Update the selector/reference in the CommandDialog styling logic to
match the new data-cmdk-input-wrapper attribute, and verify the command input
wrapper and its SVG stay aligned by using the same unique identifiers in the JSX
and CSS selector.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 67dd2b5f-c14d-49eb-ac2b-39965e7c272f
📒 Files selected for processing (8)
frontend/app/chat/_components/assistant-message.tsxfrontend/app/knowledge/page.tsxfrontend/components/cloud-picker/unified-cloud-picker.tsxfrontend/components/dev-role-toggle.tsxfrontend/components/knowledge-dropdown.tsxfrontend/components/navigation.tsxfrontend/components/ui/command.tsxfrontend/lib/task-utils.ts
💤 Files with no reviewable changes (1)
- frontend/components/knowledge-dropdown.tsx
github-actions
Bot
added
enhancement
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@frontend/.github/workflows/react-doctor.yml`:
- Around line 1-50: The React Doctor workflow is placed under a nested
.github/workflows directory, so GitHub won’t discover it. Move the
react-doctor.yml workflow to the repository-root .github/workflows folder and
keep the same job definition and triggers so the existing react-doctor job
continues to run.
- Line 32: The React Doctor workflow uses actions/checkout without full history,
which can cause incorrect PR baselining. Update the checkout step in the
workflow to include fetch-depth: 0 so React Doctor can compare against the merge
base correctly; use the existing actions/checkout step as the location to
adjust.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: ba0acf08-be67-4bfd-8f8b-994db3282efc
📒 Files selected for processing (1)
frontend/.github/workflows/react-doctor.yml
github-actions
Bot
added
enhancement
github-actions
Bot
added
enhancement
github-actions
Bot
added
enhancement
github-actions
Bot
added
enhancement
Wallgau
approved these changes
Jun 30, 2026
Wallgau
left a comment
Wallgau
left a comment
Collaborator
There was a problem hiding this comment.
Nice work! One small thing: this PR uses actions/checkout@v5, while lint-frontend.yml (and most of the other workflows) are still on @v4, and codeql.yml is on @v6. Nothing will break since they're all valid versions, but it leaves us with a mix of versions that's a bit harder to maintain. Would it make sense to standardize on a single version across the repo?
github-actions
Bot
added
enhancement
github-actions
Bot
added
enhancement
github-actions
Bot
added
enhancement
This was referenced Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds react doctor to the ci.
The current score is at 42 we'll start by blocking changes that drop it below 40
Also adds a series of fixes
Summary by CodeRabbit
Bug Fixes
Refactor