fix: remove os data as part of reset

[edwinjosechittilappilly]

fix: remove os data as part of reset

Summary by CodeRabbit

• Documentation

  • Clarified full factory reset guidance to mention removal of legacy OpenSearch data.
  • Updated the reset warning text to reflect the additional cleanup step.

• Bug Fixes

  • Factory reset now removes any existing opensearch-data directory, helping prevent old index files from remaining after cleanup.
  • Added clearer messaging during reset, including success and warning output if cleanup cannot be completed.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 1f3ee7b5-77f3-444e-99a1-d9194e57f76a

📥 Commits

Reviewing files that changed from the base of the PR and between 3fd8b61 and 1a69b59.

📒 Files selected for processing (1)

• Makefile

🚧 Files skipped from review as they are similar to previous changes (1)

• Makefile

---

Walkthrough

The factory-reset Makefile target is updated to conditionally detect and remove a local opensearch-data directory, with success/failure messages. CONTRIBUTING.md and the MDX warning partial are updated to document this additional cleanup step.

Changes

Factory Reset opensearch-data Cleanup

Layer / File(s)	Summary
Makefile cleanup step and documentation updates Makefile, CONTRIBUTING.md, docs/docs/_partial-factory-reset-warning.mdx	factory-reset target now lists opensearch-data in its upfront warning and conditionally removes that directory during execution. CONTRIBUTING.md and the MDX warning partial are updated to mention the legacy directory removal.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title matches the main change: factory reset now removes legacy OpenSearch data.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix-reset-remove-os-data

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Caution

Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted.

Error details

{}

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@Makefile`:
- Around line 624-628: The factory-reset confirmation summary is missing the new
opensearch-data deletion, so update the warning text shown before confirmation
to include that directory alongside the existing local data paths. Make this
change in the Makefile target that drives the reset flow, keeping the summary
aligned with the destructive actions performed by the reset logic that removes
opensearch-data.
- Around line 624-627: The opensearch-data cleanup block in the Makefile always
reports success even if rm -rf fails, so adjust that cleanup path to surface
failures instead of unconditionally printing the removed message. Update the
opensearch-data removal logic to check the return status of the cleanup command
and only emit the success message when deletion actually succeeds, using the
existing opensearch-data cleanup block as the target for the fix.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a0623e60-6d26-4f89-bf42-b0670cc988a4

📥 Commits

Reviewing files that changed from the base of the PR and between 74fe6be and 3fd8b61.

📒 Files selected for processing (3)

• CONTRIBUTING.md
• Makefile
• docs/docs/_partial-factory-reset-warning.mdx

[mpawlow]

Code Review 1

• ✅ Approved / LGTM 🚀
• See PR review comments: (1a), (1b) for Minor severity optional consideration (same as CodeRabbit)

[github-actions]

Build successful! ✅
Deploying docs draft.
Deploy successful! View draft