Skip to content

fix: add endpoint to browse connection files for connectors#1579

Merged
ricofurtado merged 1 commit into
mainfrom
add-missing-route-from-bucket-files-selection-back
May 15, 2026
Merged

fix: add endpoint to browse connection files for connectors#1579
ricofurtado merged 1 commit into
mainfrom
add-missing-route-from-bucket-files-selection-back

Conversation

@ricofurtado

@ricofurtado ricofurtado commented May 11, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • New Features
    • Added the ability to browse connection files for connector integrations through a new internal endpoint.

Review Change Stack

@coderabbitai

coderabbitai Bot commented May 11, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 287d0cae-6a53-4bdc-8605-3fe8ca9b794b

📥 Commits

Reviewing files that changed from the base of the PR and between e74483c and 6f4697e.

📒 Files selected for processing (1)
  • src/app/routes/internal.py

Walkthrough

This PR adds a single internal FastAPI endpoint that enables browsing connector connection files. The new GET route /connectors/{connector_type}/{connection_id}/browse is wired to the connectors.browse_connection_files handler.

Changes

File Browse Route

Layer / File(s) Summary
Browse Files Endpoint
src/app/routes/internal.py
New internal GET route /connectors/{connector_type}/{connection_id}/browse mapped to connectors.browse_connection_files.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

bug

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding an endpoint to browse connection files for connectors, which matches the code addition of the /connectors/{connector_type}/{connection_id}/browse route.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch add-missing-route-from-bucket-files-selection-back

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added backend 🔷 Issues related to backend services (OpenSearch, Langflow, APIs) bug 🔴 Something isn't working. labels May 11, 2026

@mpawlow mpawlow left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ricofurtado

Code Review 1

  • ✅ LGTM / Approved 🚀

@github-actions github-actions Bot added the lgtm label May 13, 2026
@ricofurtado
ricofurtado merged commit 869599f into main May 15, 2026
14 of 17 checks passed
@github-actions
github-actions Bot deleted the add-missing-route-from-bucket-files-selection-back branch May 15, 2026 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend 🔷 Issues related to backend services (OpenSearch, Langflow, APIs) bug 🔴 Something isn't working. lgtm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants