fix: correct CEL evaluation for strict seccomp inheritance#1496
Conversation
Signed-off-by: harinandhreddy0411 <harinandhreddy@gmail.com>
97c426b to
25b94bb
Compare
|
@harinandhreddy0411 Thanks for the PR. Could you please complete the PR template, including the Related Issue, Description, and testing details? Having that context will help with the review. |
Thanks for the heads-up! I just updated the PR description with the related issue (#1446), the description, and the checklist. |
|
/assign |
There was a problem hiding this comment.
Pull request overview
This pull request fixes the CEL validation logic for the restrict-seccomp-strict (Restricted) Pod Security Standards policy so that container-level seccomp settings are evaluated correctly when inheriting from the Pod-level spec.securityContext.seccompProfile.type.
Changes:
- Updates the CEL expressions to require each (init/ephemeral/regular) container to either set an allowed
seccompProfile.type(RuntimeDefault/Localhost) or inherit an allowed value from the Pod securityContext. - Updates validation messages to reflect the “explicitly set or inherited” behavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@harinandhreddy0411 Thanks for the PR! It looks like some checks are currently failing. I'll take a closer look once they're green. |
Updated Seccomp profile validation expressions to enforce restrictions on custom profiles. Signed-off-by: harinandhreddy0411 <harinandhreddy@gmail.com>
|
Hi @realshuting, I've pushed the fixes for the artifacthub digest and the CEL expression syntax. It looks like the workflows are currently awaiting approval to run the CI tests. Could you please trigger the workflow approval when you have a moment? |
|
Hi @Suhani95, just wanted to ping you on this since you were the one who originally caught the failing checks! I have updated the artifacthub-pkg.yml digest and fixed the CEL expression syntax. I tagged Shuting earlier to approve the workflow run, but I know the core team is swamped with the release. If you have a few minutes to review the new changes (or if you have the permissions to trigger the CI workflows so they can turn green), I would really appreciate it! |
Signed-off-by: harinandhreddy0411 <harinandhreddy@gmail.com>
Signed-off-by: harinandhreddy0411 <harinandhreddy@gmail.com>
Signed-off-by: harinandhreddy0411 <harinandhreddy@gmail.com>
|
Done! @Suhani95 I have added the regression test cases for both the inherited and completely unset scenarios in the test resources. |
Related Issue(s)
Closes #1446
Description
This PR fixes the CEL evaluation logic for strict seccomp inheritance. It addresses the behavior mismatch reported when transforming the
restrict-seccomp-strictClusterPolicy into CEL-Expressions.Checklist