📖 doc(path): improve documentation about path behaviour#1438
📖 doc(path): improve documentation about path behaviour#1438camilamacedo86 wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
camilamacedo86
changed the title
camilamacedo86
force-pushed
the
add-doc-options
branch
3 times, most recently
from
ed47eff to
2cd0cb4
Compare
nirs
left a comment
nirs
left a comment
There was a problem hiding this comment.
Looks good, describes complicated behavior in a helpful way.
I wonder how is this rendered in the book? any preview?
| // preferred brace-delimited form: | ||
| // | ||
| // paths="{./api/..., ./pkg/...}" | ||
| // paths=./api/...;./pkg/... |
There was a problem hiding this comment.
Do we really want to document both ways? Isn't ; deprecated?
There was a problem hiding this comment.
It is not deprecated. Where you checked that the usage paths=./api/...;./pkg/... is deprecated?
| // | ||
| // paths=./... | ||
| // paths=./api/v1 | ||
| // paths=/home/user/project/api |
There was a problem hiding this comment.
Using one space to indent the example is not very clear - looks like a formatting mistake instead of intentional indentation. Is this rendered in a better way?
There was a problem hiding this comment.
Good catcher we should fix and do like other places.
Done.
camilamacedo86
force-pushed
the
add-doc-options
branch
from
2cd0cb4 to
f66f4a4
Compare
camilamacedo86
left a comment
camilamacedo86
left a comment
There was a problem hiding this comment.
Hi @nirs
Thank you for your help here.
Could you please give a look again?
I think it is great to get merged now.
Thx
camilamacedo86
force-pushed
the
add-doc-options
branch
from
f66f4a4 to
226ffa4
Compare
camilamacedo86
force-pushed
the
add-doc-options
branch
from
226ffa4 to
ae87647
Compare
|
Hi @nirs Could you please give a look? Are you Ok with? If yes, could you please LGTM? Regards
That will be rendered the same way as the other docs and examples. |
3 participants
closes: #1421