🐛 Fix marker parser misinterpreting number-ish strings as numeric literals by sivchari · Pull Request #1366 · kubernetes-sigs/controller-tools

sivchari · 2026-03-17T03:11:27Z

Close #734
Close #879

Signed-off-by: sivchari <shibuuuu5@gmail.com>

JoelSpeed

@sivchari can you provide an example of where this bit you? Would be good to understand the motivation for this change before we accept it

sivchari · 2026-03-30T02:15:03Z

I've not ran into this problem. I just try to fix #879 and #734.
Updated pr description.

camilamacedo86 · 2026-04-19T11:35:01Z

 			It("should support non-uniform, nested maps (and always guess as such)", argParseTestCase{arg: anyArg, raw: `{text: "abc", len: 3, "as bytes": 97;98;99, props: {encoding: ascii, nullsafe: true, tags: {"triple", "in a row"}}}`, output: complexMap}.Run)
+
+			It("should parse number-ish strings with invalid octal prefix as string", argParseTestCase{arg: anyArg, raw: `087bdd`, output: "087bdd"}.Run)
+			It("should parse path-like strings as string", argParseTestCase{arg: anyArg, raw: `/tmp/tmp.4paHkdEcpK`, output: "/tmp/tmp.4paHkdEcpK"}.Run)


Could you please add test for path-like case from #734 (e.g.,
"123/path") to ensure better coverage?

Suggested change

It("should parse path-like strings as string", argParseTestCase{arg: anyArg, raw: `/tmp/tmp.4paHkdEcpK`, output: "/tmp/tmp.4paHkdEcpK"}.Run)

It("should parse path-like strings as string", argParseTestCase{arg: anyArg, raw: `/tmp/tmp.4paHkdEcpK`, output: "/tmp/tmp.4paHkdEcpK"}.Run)

It("should parse path-like strings as string", argParseTestCase{arg: anyArg, raw: `/tmp/tmp.4paHkdEcpK`, output: "/tmp/tmp.4paHkdEcpK"}.Run)

It("should parse numeric path as string", argParseTestCase{arg: anyArg, raw: `123/config`, output: "123/config"}.Run)

It("should parse invalid octal number as string", argParseTestCase{arg: anyArg, raw: `0987`, output: "0987"}.Run)

It("should parse resource quantity as string", argParseTestCase{arg: anyArg, raw: `100Mi`, output: "100Mi"}.Run)

It("should parse date-like string as string", argParseTestCase{arg: anyArg, raw: `2024-01-15`, output: "2024-01-15"}.Run)

It("should parse SHA prefix as string", argParseTestCase{arg: anyArg, raw: `sha256:08a7b`, output: "sha256:08a7b"}.Run)

It("should parse UUID-like string as string", argParseTestCase{arg: anyArg, raw: `00000000-1234-5678`, output: "00000000-1234-5678"}.Run)

It("should parse alphanumeric starting with number as string", argParseTestCase{arg: anyArg, raw: `123abc`, output: "123abc"}.Run)

@sivchari could you please add those ?
Then , I am have to LGTM this one.

Thx! I added these testcases.

camilamacedo86

Just missing more test to cover all scenarios.
thank you for the contribution 🎉

camilamacedo86

/lgtm

k8s-ci-robot · 2026-04-27T08:31:52Z

LGTM label has been added.

Details

Git tree hash: fcf7b683c6adaf359716e99ad7dd629ce2a76958

camilamacedo86 · 2026-06-18T05:30:31Z

Hi @sbueringer @JoelSpeed @alvaroaleman

This one I checked already.
It seems good to get merged.

Could you please give a look and see if we can get this one merged?

Signed-off-by: sivchari <shibuuuu5@gmail.com>

camilamacedo86

/lgtm

k8s-ci-robot · 2026-06-18T13:54:29Z

LGTM label has been added.

Details

Git tree hash: a9549fcea968b86c39e0c12e2c2f3917965f1b32

k8s-ci-robot · 2026-06-18T13:54:30Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: camilamacedo86, sivchari
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

camilamacedo86 · 2026-06-18T13:54:43Z

/ok-to-test

k8s-ci-robot requested review from alvaroaleman and sbueringer March 17, 2026 03:11

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 17, 2026

Fix marker parser misinterpreting number-ish strings as numeric literals

9c43c07

Signed-off-by: sivchari <shibuuuu5@gmail.com>

sivchari force-pushed the fix/marker-parser-numeric-literal-error branch from 7f58243 to 9c43c07 Compare March 27, 2026 03:02

JoelSpeed reviewed Mar 27, 2026

View reviewed changes

camilamacedo86 reviewed Apr 19, 2026

View reviewed changes

This was referenced Apr 21, 2026

controller-gen interprets path as numeric literal and fails #734

Open

Custom Flag/Arg Parsing Library Fails On Octal-looking Strings #879

Open

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 27, 2026

camilamacedo86 approved these changes Apr 27, 2026

View reviewed changes

k8s-ci-robot assigned camilamacedo86 Apr 27, 2026

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 27, 2026

fix parser logic to parse some patterns as strings

bc6f44c

Signed-off-by: sivchari <shibuuuu5@gmail.com>

sivchari force-pushed the fix/marker-parser-numeric-literal-error branch from 4ecab7f to bc6f44c Compare June 18, 2026 05:43

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 18, 2026

k8s-ci-robot requested a review from camilamacedo86 June 18, 2026 05:43

camilamacedo86 approved these changes Jun 18, 2026

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 18, 2026

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 18, 2026

alvaroaleman added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jun 18, 2026

-			It("should parse path-like strings as string", argParseTestCase{arg: anyArg, raw: `/tmp/tmp.4paHkdEcpK`, output: "/tmp/tmp.4paHkdEcpK"}.Run)
+			It("should parse path-like strings as string", argParseTestCase{arg: anyArg, raw: `/tmp/tmp.4paHkdEcpK`, output: "/tmp/tmp.4paHkdEcpK"}.Run)
+			It("should parse path-like strings as string", argParseTestCase{arg: anyArg, raw: `/tmp/tmp.4paHkdEcpK`, output: "/tmp/tmp.4paHkdEcpK"}.Run)
+			It("should parse numeric path as string", argParseTestCase{arg: anyArg, raw: `123/config`, output: "123/config"}.Run)
+			It("should parse invalid octal number as string", argParseTestCase{arg: anyArg, raw: `0987`, output: "0987"}.Run)
+			It("should parse resource quantity as string", argParseTestCase{arg: anyArg, raw: `100Mi`, output: "100Mi"}.Run)
+			It("should parse date-like string as string", argParseTestCase{arg: anyArg, raw: `2024-01-15`, output: "2024-01-15"}.Run)
+			It("should parse SHA prefix as string", argParseTestCase{arg: anyArg, raw: `sha256:08a7b`, output: "sha256:08a7b"}.Run)
+			It("should parse UUID-like string as string", argParseTestCase{arg: anyArg, raw: `00000000-1234-5678`, output: "00000000-1234-5678"}.Run)
+			It("should parse alphanumeric starting with number as string", argParseTestCase{arg: anyArg, raw: `123abc`, output: "123abc"}.Run)

Uh oh!

Conversation

sivchari commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JoelSpeed left a comment

Choose a reason for hiding this comment

Uh oh!

sivchari commented Mar 30, 2026

Uh oh!

camilamacedo86 Apr 19, 2026

Choose a reason for hiding this comment

Uh oh!

camilamacedo86 Apr 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sivchari Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

camilamacedo86 left a comment

Choose a reason for hiding this comment

Uh oh!

camilamacedo86 left a comment

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Apr 27, 2026

Uh oh!

camilamacedo86 commented Jun 18, 2026

Uh oh!

camilamacedo86 left a comment

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Jun 18, 2026

Uh oh!

k8s-ci-robot commented Jun 18, 2026

Uh oh!

camilamacedo86 commented Jun 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sivchari commented Mar 17, 2026 •

edited

Loading

camilamacedo86 Apr 19, 2026 •

edited

Loading