Extend IBMVPCMachineSpec to allow gen2 storage

[Pacho20]

What this PR does / why we need it:
This PR extends IBMVPCMachineSpec to support a new sdp profile, which is a second-generation storage solution for VSIs offering significantly improved performance. Users can now define clusters that leverage this new storage. The changes are backward-compatible, adding a new profile value and an optional field without breaking the existing API.

Release note:

Extend IBMVPCMachineSpec to allow gen2 storage

[netlify]

✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name	Link
🔨 Latest commit	0d1083e
🔍 Latest deploy log	https://app.netlify.com/projects/kubernetes-sigs-cluster-api-ibmcloud/deploys/6a392c7953a63a0008a34c03
😎 Deploy Preview	https://deploy-preview-2811.cluster-api-ibmcloud.sigs.k8s.io
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Pacho20
Once this PR has been reviewed and has the lgtm label, please assign prajyot-parab for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @Pacho20. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Prajyot-Parab]

/cc @Karthik-K-N

[Prajyot-Parab]

/ok-to-test

[kubernetes-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Pacho20
Once this PR has been reviewed and has the lgtm label, please assign prajyot-parab for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[aman4433]

I noticed we now validate the profile-specific max size for sdp boot volumes, while additional volumes still only check that sizeGiB is non-zero. Should we also enforce the sdp max size for additional volumes here, or are we intentionally relying on the VPC API for additional volume size limits? Not a blocker if this is existing validation behavior.

[Amulyam24]

@Pacho20, the API changes should be going into v1beta2 as that is the current version maintained for VPC. v1beta1 can be ignored.

[Amulyam24]

/cc @anshuman-agarwala

[anshuman-agarwala]

LGTM aside from the v1beta1 issue.
Do you mind attaching screenshots of what ibmvpcmachine resources look like with the new volume types?