Skip to content

✨ Add missing, desired routes during route table reconciliation#6047

Open
AndiDog wants to merge 1 commit into
kubernetes-sigs:mainfrom
AndiDog:add-missing-route-reconciliation
Open

✨ Add missing, desired routes during route table reconciliation#6047
AndiDog wants to merge 1 commit into
kubernetes-sigs:mainfrom
AndiDog:add-missing-route-reconciliation

Conversation

@AndiDog

@AndiDog AndiDog commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

For bring-your-own VPCs that miss routes such as 0.0.0.0/0, CAPA should create the desired routes. Therefore I implemented creation, while previously the code only fixed mismatching, existing routes (update). I specifically did not implement full reconciliation, i.e. deletion, since that could be a breaking, dangerous change.

This also includes an improvement for event/log formatting since %s can't format a struct reasonably.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Special notes for your reviewer:

AI Usage:

I used Claude to create a failing test, then to rewrite and simplify existing logic to do both create+update. Basically the same as I would've done on my own, plus human check all along the way.

Checklist:

  • squashed commits
  • includes documentation
  • includes AI generated content
  • includes emoji in title
  • adds unit tests
  • adds or updates e2e tests

Release note:

Add missing, desired routes during route table reconciliation

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Jun 11, 2026
@k8s-ci-robot k8s-ci-robot requested a review from fiunchinho June 11, 2026 16:16
@k8s-ci-robot k8s-ci-robot requested a review from nrb June 11, 2026 16:16
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign andidog for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants